Pass the dir config options to plugins
#1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadeByMike
changed the title
dir config options to pluginsdir config options to plugins
|
Thank you! Only a year later 👀 |
zachleat
added a commit
that referenced
this pull request
Jul 28, 2021
This was referenced Jul 29, 2021
zachleat
added a commit
that referenced
this pull request
Aug 6, 2021
zachleat
added a commit
that referenced
this pull request
Mar 16, 2022
…have the defaults if nothing is returned from the configuration file. Related to #1320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found numerous cases where knowing the input and output dir is required for plugins.
Because of the execution of merging options it was not as simple as first imagined. I passed the responsibility for running plugins to the TemplateConfig class. This felt similar to a lot of other config options which are set and run later.
I'm looking for feedback on whether the raw config values should be passed as I've done here... or if we should resolve these further first? Also... should we pass anything else from TemplateConfig to plugins?