Remove fs-extra dependency (#1891) #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zachleat proposed removing fs-extra since the build in FS module now provides a promise based option and supports recursive options. This Commit only uses the ```require("fs")``` instead of ```require("fs").promises``` or ```require("fs/promises")```, since the last one is not support in Node Version <14 and the sync API is used. Except for Template.js no file logic needed to be changed to remove fs-extra. According to my run of "npm test" test results are not changed by this commit. Signed-off-by: Raphael Höser <raphael@hoeser.info>
zachleat
reviewed
Jul 26, 2021
| this.writeCount++; | ||
| debug(`${outputPath} ${lang.finished}.`); | ||
| }); | ||
| await fs.promises.mkdir(path.parse(outputPath).dir, { recursive: true }); |
There was a problem hiding this comment.
This is not quite the same but we’ll fix it in post!!
|
Thank you! |
This was referenced Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zachleat proposed in #1891 removing fs-extra since the build in FS module now provides a promise based option and supports recursive options.
This Commit only uses the
require("fs")instead ofrequire("fs").promisesorrequire("fs/promises"), since the last one is not support in Node Version <14 and the sync API is used.Except for Template.js no file logic needed to be changed to remove fs-extra.
According to my run of "npm test" test results are not changed by this commit.
This commit only replaces fs-extra with fs and does not touch existing logic when it's not needed. Maybe some optimizations like in 5ca1aa7 are possible.