Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for eleventy.config.js and eleventy.config.cjs config files by default #1028 #1029 #2464

Conversation

Snapstromegon
Copy link
Member

@Snapstromegon Snapstromegon commented Jun 29, 2022

Currently only .eleventy.js is supported as the default config file.

This PR implements a possible solution for multiple config file. It intentionally just implements support for multiple default config files.

The implementation might be a little flaky around unittests, but it passes all of them consistently.

A future PR should probably look into allowing usage of multiple config files at once. This only uses the first existing one.

fixes #1028
fixes #1029

…ult eleventy config files

Currently only .eleventy.js is supported as the default config file.

This PR implements a possible solution for multiple config file. It intentionally just implements support for multiple default config files.

The implementation might be a little flaky around unittests, but it passes all of them consistently.

A future PR should probably look into allowing usage of multiple config files at once. This only uses the first existing one.

Signed-off-by: Raphael Höser <raphael@hoeser.info>
@zachleat zachleat added this to the Eleventy 2.0.0 milestone Aug 16, 2022
@zachleat zachleat merged commit 56742fc into 11ty:master Aug 16, 2022
@zachleat
Copy link
Member

We are going for it! Thank you @Snapstromegon!

I might reorder the file lookup array but it looked great!

@zachleat
Copy link
Member

v2.0.0-canary.15

@zachleat
Copy link
Member

Decided against .eleventy.cjs, reasoning here: #1028 (comment)

@zachleat zachleat changed the title #1028 #1029 Possible first implementation for additional default eleventy config files Look for eleventy.config.js and eleventy.config.cjs config files by default #1028 #1029 Aug 16, 2022
@zachleat zachleat added the feature: 🛠 configuration Related to Eleventy’s Configuration file label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: 🛠 configuration Related to Eleventy’s Configuration file
Projects
None yet
3 participants