Make Markdown library .set() method optional #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will ship with v2.0.0 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tiny improvement in ergonomics for replacing the underlying Markdown library.
Due to some issues with
eleventyConfig.addExtension('md'), namely that it opts you out of pre-processing (#2777) and that it causes issues with permalinks (#2780),eleventyConfig.setLibrary('md')remains the best way to replace the library.At the moment, the library is tacitly assumed to be
markdown-it, due to usage of library-specific methods (set(),render(),disable()), but there's no other reason why another library wouldn't work, as long as it provides arender(str, data)method.This PR makes the
set()method optional in the replacement library.