-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-12 gcc-11 build error #17
Comments
Can you try this patch: The bug report from v8: https://bugs.chromium.org/p/v8/issues/detail?id=11707 |
Yes, this patch helped (I corrected it a bit):
Unfortunately, a new error (~ 30k / 38k files, a day of compilation on my old laptop):
|
--- a/media/blink/multibuffer_data_source.cc
+++ b/media/blink/multibuffer_data_source.cc
@@ -5,6 +5,7 @@
#include "media/blink/multibuffer_data_source.h"
#include <utility>
+#include <initializer_list>
#include "base/bind.h"
#include "base/callback_helpers.h"
@@ -62,10 +63,10 @@
constexpr base::TimeDelta kSeekDelay = base::TimeDelta::FromMilliseconds(20);
std::vector<std::string>* GetStreamingSchemes() {
- static base::NoDestructor<std::vector<std::string>> streaming_schemes({
+ static base::NoDestructor<std::vector<std::string>> streaming_schemes(std::initializer_list<std::string>({
url::kHttpsScheme,
url::kHttpScheme
- });
+ }));
return streaming_schemes.get();
} This code is added by https://github.com/electron/electron/blob/12-x-y/patches/chromium/feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch |
This patch also helped. And now, after additional +15 hours of compilation, Electron12 is ready! |
may be, because: https://www.electronjs.org/docs/development/build-instructions-linux#using-compilers-other-than-clang
log:
[730/38131] g++ -MMD -MF obj/v8/cppgc_base/pointer-policies.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_EMBEDDER_STRING=\"-electron.0\" -DV8_PROMISE_INTERNAL_FIELD_COUNT=1 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0 -DENABLE_MINOR_MC -DV8_INTL_SUPPORT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ATOMIC_MARKING_STATE -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_SNAPSHOT_COMPRESSION -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -DV8_NO_ARGUMENTS_ADAPTOR -DCPPGC_CAGED_HEAP -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_LINUX -DDISABLE_UNTRUSTED_CODE_MITIGATIONS -DHIDE_PRIVATE_SYMBOLS -DBUILDING_V8_SHARED -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -DV8_NO_ARGUMENTS_ADAPTOR -DCPPGC_CAGED_HEAP -I../.. -Igen -I../../v8 -I../../v8/include -Igen/v8 -I../../v8/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -pthread -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -Wno-comments -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-unused-parameter -fno-omit-frame-pointer -fvisibility=hidden -Wno-strict-overflow -Wno-return-type -Wno-int-in-bool-context -std=gnu++14 -Wno-narrowing -Wno-class-memaccess -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -march=native -O3 -pipe -fomit-frame-pointer -w -s -U_FORTIFY_SOURCE -c ../../v8/src/heap/cppgc/pointer-policies.cc -o obj/v8/cppgc_base/pointer-policies.o FAILED: obj/v8/cppgc_base/pointer-policies.o g++ -MMD -MF obj/v8/cppgc_base/pointer-policies.o.d -DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DV8_EMBEDDER_STRING=\"-electron.0\" -DV8_PROMISE_INTERNAL_FIELD_COUNT=1 -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0 -DENABLE_MINOR_MC -DV8_INTL_SUPPORT -DV8_USE_EXTERNAL_STARTUP_DATA -DV8_ATOMIC_OBJECT_FIELD_WRITES -DV8_ATOMIC_MARKING_STATE -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH -DV8_SNAPSHOT_COMPRESSION -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -DV8_NO_ARGUMENTS_ADAPTOR -DCPPGC_CAGED_HEAP -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS -DV8_TARGET_OS_LINUX -DDISABLE_UNTRUSTED_CODE_MITIGATIONS -DHIDE_PRIVATE_SYMBOLS -DBUILDING_V8_SHARED -DV8_COMPRESS_POINTERS -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_DEPRECATION_WARNINGS -DV8_NO_ARGUMENTS_ADAPTOR -DCPPGC_CAGED_HEAP -I../.. -Igen -I../../v8 -I../../v8/include -Igen/v8 -I../../v8/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -pthread -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-deprecated-declarations -Wno-comments -Wno-packed-not-aligned -Wno-missing-field-initializers -Wno-unused-parameter -fno-omit-frame-pointer -fvisibility=hidden -Wno-strict-overflow -Wno-return-type -Wno-int-in-bool-context -std=gnu++14 -Wno-narrowing -Wno-class-memaccess -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -march=native -O3 -pipe -fomit-frame-pointer -w -s -U_FORTIFY_SOURCE -c ../../v8/src/heap/cppgc/pointer-policies.cc -o obj/v8/cppgc_base/pointer-policies.o In file included from ../../v8/include/cppgc/internal/api-constants.h:11, from ../../v8/include/cppgc/internal/write-barrier.h:8, from ../../v8/include/cppgc/internal/pointer-policies.h:11, from ../../v8/src/heap/cppgc/pointer-policies.cc:5: ../../v8/include/v8config.h:465:22: error: expected identifier before ‘[’ token 465 | #define V8_NODISCARD [[nodiscard]] | ^ ../../v8/src/heap/cppgc/object-allocator.h:36:27: note: in expansion of macro ‘V8_NODISCARD’ 36 | class V8_EXPORT_PRIVATE V8_NODISCARD NoAllocationScope final { | ^~~~~~~~~~~~ In file included from ../../v8/src/heap/cppgc/heap-base.h:17, from ../../v8/src/heap/cppgc/heap.h:13, from ../../v8/src/heap/cppgc/pointer-policies.cc:10: ../../v8/src/heap/cppgc/object-allocator.h:36:40: error: expected ‘;’ at end of member declaration 36 | class V8_EXPORT_PRIVATE V8_NODISCARD NoAllocationScope final { | ^~~~~~~~~~~~~~~~~ | ; ../../v8/src/heap/cppgc/object-allocator.h:36:58: error: ‘final’ does not name a type 36 | class V8_EXPORT_PRIVATE V8_NODISCARD NoAllocationScope final { | ^~~~~ In file included from ../../v8/include/cppgc/internal/api-constants.h:11, from ../../v8/include/cppgc/internal/write-barrier.h:8, from ../../v8/include/cppgc/internal/pointer-policies.h:11, from ../../v8/src/heap/cppgc/pointer-policies.cc:5: ../../v8/include/v8config.h:465:22: error: expected identifier before ‘[’ token 465 | #define V8_NODISCARD [[nodiscard]] | ^ ../../v8/src/heap/cppgc/heap-base.h:58:27: note: in expansion of macro ‘V8_NODISCARD’ 58 | class V8_EXPORT_PRIVATE V8_NODISCARD NoGCScope final { | ^~~~~~~~~~~~ In file included from ../../v8/src/heap/cppgc/heap.h:13, from ../../v8/src/heap/cppgc/pointer-policies.cc:10: ../../v8/src/heap/cppgc/heap-base.h:58:40: error: expected ‘;’ at end of member declaration 58 | class V8_EXPORT_PRIVATE V8_NODISCARD NoGCScope final { | ^~~~~~~~~ | ; ../../v8/src/heap/cppgc/heap-base.h:58:50: error: ‘final’ does not name a type 58 | class V8_EXPORT_PRIVATE V8_NODISCARD NoGCScope final { | ^~~~~ [731/38131] python ../../tools/licenses.py --target-os=linux --depfile gen/components/resources/about_credits.d credits gen/components/resources/about_credits.html ninja: build stopped: subcommand failed.
The text was updated successfully, but these errors were encountered: