Add emoji extension to commonmark (#245)

123inkt · Apr 23, 2023 · 2ab8707 · 2ab8707
1 parent fbb92d5
commit 2ab8707
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 2 deletions.
diff --git a/composer.json b/composer.json
@@ -42,6 +42,7 @@
         "doctrine/doctrine-bundle": "^2.6",
         "doctrine/doctrine-migrations-bundle": "^3.2",
         "doctrine/orm": "^2.12",
+        "fdekker/commonmark-ext-emoji": "^1.0",
         "league/commonmark": "^2.3",
         "league/uri": "^6.8",
         "nesbot/carbon": "^2.64",

diff --git a/composer.lock b/composer.lock
diff --git a/src/Service/CodeReview/Comment/CommonMarkdownConverter.php b/src/Service/CodeReview/Comment/CommonMarkdownConverter.php
@@ -3,6 +3,7 @@
 
 namespace DR\Review\Service\CodeReview\Comment;
 
+use FD\CommonMarkEmoji\EmojiExtension;
 use League\CommonMark\Environment\Environment;
 use League\CommonMark\Extension\CommonMark\CommonMarkCoreExtension;
 use League\CommonMark\Extension\CommonMark\Node\Block\FencedCode;
@@ -46,6 +47,7 @@ public function __construct()
         );
         $environment->addExtension(new CommonMarkCoreExtension());
         $environment->addExtension(new GithubFlavoredMarkdownExtension());
+        $environment->addExtension(new EmojiExtension());
         $environment->addRenderer(FencedCode::class, new FencedCodeRenderer(self::LANGUAGES));
 
         parent::__construct($environment);

diff --git a/tests/Unit/Service/CodeReview/Comment/CommonMarkdownConverterTest.php b/tests/Unit/Service/CodeReview/Comment/CommonMarkdownConverterTest.php
@@ -22,7 +22,7 @@ public function testConstruct(): void
         $environment = $converter->getEnvironment();
 
         $extension = $environment->getExtensions();
-        static::assertCount(2, $extension);
+        static::assertCount(3, $extension);
 
         $renderers = [...$environment->getRenderersForClass(FencedCode::class)];
         static::assertCount(2, $renderers);