Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist war room across the app #23

Closed
amorriscode opened this issue Feb 24, 2022 · 0 comments · Fixed by #43
Closed

Persist war room across the app #23

amorriscode opened this issue Feb 24, 2022 · 0 comments · Fixed by #43
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@amorriscode
Copy link
Member

Right now, if you join a War Room and click on any tabs, it closes. We should use context/local storage and allow the War Room to persist between pages.
@amorriscode amorriscode added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 24, 2022
@amorriscode amorriscode mentioned this issue Mar 5, 2022
Merged
3 tasks
amorriscode added a commit that referenced this issue Mar 5, 2022
@amorriscode
feat: make War Room global across the app (#43)
b71def1 
### tl;dr

- [x] Adds `WarRoomProvider` so that we can join a war room and have it persist across the app
- [x] Fixes issue with the Incidents nav item incorrectly being active
- [x] Resolves #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
War Room
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make War Room global across the app 12products/warroom-frontend
1 participant
@amorriscode