Duplication mitigations #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Code Climate has analyzed commit 15696df and detected 0 issues on this pull request. View more on Code Climate. |
1337-server
added a commit
that referenced
this pull request
Mar 19, 2022
* refactored into functions * added handling harness for script options * added logic to run proper installation function * Fixed errors * added pycharm-community install * implemented install_arm_dev_env * implemented launch_setup * added call for launch_setup * minor change for clarity * hard-coding path since the user folder is already created * refactored to run in correct dirs * fixed command to run under arm user * fix command to properly run without hanging script * moved dev environment installation location * grab the ip of the site that's now running * fixed errors and added logic * Fixed permissions issue * removed deprecated file * pycharm runs as "other", so the 777 is needed * rollback broken queries merged by #112 * added ALSA install to script to avoid breakage on Ubuntu Server instances * Added handling for arm group/user already existing * Added installs for lsscsi and net-tools * Added coloration to logging statements * Added Markdown v3.3.4 explicitly to requirements.txt, to fix breaking change caused by 3.3.5 (see Python-Markdown/markdown#1203) * Putting alsa install first to hopefully fix continuing error calling aplay in scripts * fixed out of order parameters * fixed bad parameter * updated the clone command for testing updated requirements * moved checkout command a better spot * fixed typo * fixed typo * Ubuntu loud script fix for 1337-server/automatic-ripping-machine issue #111 * Ubuntu quiet script fix for 1337-server/automatic-ripping-machine issue #111 * added logic to prevent duplicating fstab entries * Moved heredocs to custom files * fixed typos * fix for broken service start * refactored into functions * added handling harness for script options * added logic to run proper installation function * Fixed errors * added pycharm-community install * implemented install_arm_dev_env * implemented launch_setup * added call for launch_setup * minor change for clarity * hard-coding path since the user folder is already created * refactored to run in correct dirs * fixed command to run under arm user * fix command to properly run without hanging script * moved dev environment installation location * grab the ip of the site that's now running * fixed errors and added logic * Fixed permissions issue * removed deprecated file * pycharm runs as "other", so the 777 is needed * added ALSA install to script to avoid breakage on Ubuntu Server instances * Added handling for arm group/user already existing * Added installs for lsscsi and net-tools * Added coloration to logging statements * Added Markdown v3.3.4 explicitly to requirements.txt, to fix breaking change caused by 3.3.5 (see Python-Markdown/markdown#1203) * Putting alsa install first to hopefully fix continuing error calling aplay in scripts * fixed out of order parameters * fixed bad parameter * updated the clone command for testing updated requirements * moved checkout command a better spot * fixed typo * fixed typo * Ubuntu loud script fix for 1337-server/automatic-ripping-machine issue #111 * Ubuntu quiet script fix for 1337-server/automatic-ripping-machine issue #111 * added logic to prevent duplicating fstab entries * Moved heredocs to custom files * fixed typos * fix for broken service start * refactored into functions * added handling harness for script options * added logic to run proper installation function * Fixed errors * added pycharm-community install * implemented install_arm_dev_env * implemented launch_setup * added call for launch_setup * minor change for clarity * hard-coding path since the user folder is already created * refactored to run in correct dirs * fixed command to run under arm user * fix command to properly run without hanging script * moved dev environment installation location * grab the ip of the site that's now running * fixed errors and added logic * Fixed permissions issue * removed deprecated file * pycharm runs as "other", so the 777 is needed * added ALSA install to script to avoid breakage on Ubuntu Server instances * Added handling for arm group/user already existing * Added installs for lsscsi and net-tools * Added coloration to logging statements * Added Markdown v3.3.4 explicitly to requirements.txt, to fix breaking change caused by 3.3.5 (see Python-Markdown/markdown#1203) * Putting alsa install first to hopefully fix continuing error calling aplay in scripts * fixed out of order parameters * fixed bad parameter * updated the clone command for testing updated requirements * moved checkout command a better spot * fixed typo * fixed typo * Ubuntu loud script fix for 1337-server/automatic-ripping-machine issue #111 * Ubuntu quiet script fix for 1337-server/automatic-ripping-machine issue #111 * added logic to prevent duplicating fstab entries * Moved heredocs to custom files * fixed typos * fix for broken service start * refactored into functions * added handling harness for script options * added logic to run proper installation function * Fixed errors * added pycharm-community install * implemented install_arm_dev_env * implemented launch_setup * added call for launch_setup * minor change for clarity * hard-coding path since the user folder is already created * refactored to run in correct dirs * fixed command to run under arm user * fix command to properly run without hanging script * moved dev environment installation location * grab the ip of the site that's now running * fixed errors and added logic * Fixed permissions issue * removed deprecated file * pycharm runs as "other", so the 777 is needed * Added handling for arm group/user already existing * Added installs for lsscsi and net-tools * Added coloration to logging statements * Putting alsa install first to hopefully fix continuing error calling aplay in scripts * fixed out of order parameters * fixed bad parameter * updated the clone command for testing updated requirements * moved checkout command a better spot * fixed typo * Ubuntu loud script fix for 1337-server/automatic-ripping-machine issue #111 * added logic to prevent duplicating fstab entries * Moved heredocs to custom files * fixed typos * refactored into functions * added handling harness for script options * added logic to run proper installation function * Fixed errors * added pycharm-community install * implemented install_arm_dev_env * implemented launch_setup * added call for launch_setup * minor change for clarity * hard-coding path since the user folder is already created * refactored to run in correct dirs * fixed command to run under arm user * fix command to properly run without hanging script * moved dev environment installation location * grab the ip of the site that's now running * fixed errors and added logic * Fixed permissions issue * pycharm runs as "other", so the 777 is needed * added ALSA install to script to avoid breakage on Ubuntu Server instances * Added handling for arm group/user already existing * Added installs for lsscsi and net-tools * Added coloration to logging statements * Putting alsa install first to hopefully fix continuing error calling aplay in scripts * fixed out of order parameters * fixed bad parameter * updated the clone command for testing updated requirements * moved checkout command a better spot * fixed typo * Ubuntu loud script fix for 1337-server/automatic-ripping-machine issue #111 * added logic to prevent duplicating fstab entries * Moved heredocs to custom files * fixed typos * refactored into functions * added handling harness for script options * added logic to run proper installation function * Fixed errors * added pycharm-community install * implemented install_arm_dev_env * implemented launch_setup * added call for launch_setup * minor change for clarity * hard-coding path since the user folder is already created * refactored to run in correct dirs * fixed command to run under arm user * fix command to properly run without hanging script * moved dev environment installation location * grab the ip of the site that's now running * fixed errors and added logic * Fixed permissions issue * pycharm runs as "other", so the 777 is needed * reverted changes * removed deprecated checkout * fixed typo * delete old symlinks broken by the reinstallation process * fixed typo * auto-accept bc these repos are core to the install * remove deprecated checkout command * fixed broken evaluations * fixed not finding the existing armui.service due to the space being where a / should be * stop and remove and existing ARM install to avoid FileNotFound errors caused by the service being deleted after the source code it runs is deleted during script runtime * refactored repeated logic into function run_makemkv(cmd) * added update_key.sh * installer now sets permissions for the new update_keys.sh * fixed permissions set on the service file during install * updated install scripts to set proper permissions for update_key.sh * Overhaul of makemkv.py, everything needed to be done at the same time (I know, I know...) * added noqa tags for variables that aren't being used * Nicer printing of the logging statement * Make sure each title is transcoded in order * updated LICENSE * Removed getkeys.py * Updated VERSION * Revert "Removed getkeys.py" This reverts commit 2e73b5d. * Fix bug in file sorting * Update deb-install-quiet.sh * Update debian-setup.sh * Create docker-publish.yml * Update docker-publish.yml * Update README.md * Push to dockerhub * Delete build-push-action.yml * Delete docker-publish.yml * Create docker-publish.yml * more github action tests * Update docker-publish.yml * Update docker-publish.yml * Fixes #128 - doc strings showed wrong types leading to confusion Index page will now correctly update the card header with correct details * cleaning some js code to reduce warnings/errors * cleaning some js code to reduce warnings/errors * Removing unused variables from makemkv Adding the progress from makemkv to logging Cleaning some js code to reduce warnings/errors (tested FF&Chrome) * Removing commented unused code Small refactoring to be more compliant * fix variable name * flake8 * Fixes #129 * Revert "Merge branch 'v2_master' into v2_devel" This reverts commit 58cb03a, reversing changes made to 4b0793d. Co-authored-by: wolfy <wolfy@shitwolfymakes.com> Co-authored-by: wolfy <wolfy@shitwolfymakes>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the edge case in the current filter queries, and adds debug logging to help ensure that values aren't being changed between assignment and usage. Right now, if a duplicate run occurs at anytime before the original rip completes (transcoding, etc.), it will not fail if there are no successful rips of the same disk stored in the database
To solve this, I have changed the filter statements from
WHERE status = "success"toWHERE NOT status = "fail". This will register active rips of the same disk as valid duplicates, handling this edge case.Note this shouldn't affect TV series, as each disk should have a unique
crc