install.cmd: support pyenv, fix potential %CD% bugs #152
Conversation
|
Thank you for this PR! I don't have any Windows systems to test this with nowadays. Can other Windows users test and confirm? Please use the Github review tool. |
| DEL "emjname.ttx" | ||
| call ttx -t "name" -o "emjname.ttx" %MS_EMOJI_FONT_PATH% || GOTO :ERROR | ||
| call ttx -o %FINAL_EMJ_FONT_PATH% -m %EMOJI_FONT_PATH% "%CD%\emjname.ttx" || GOTO :ERROR | ||
| DEL "%CD%\emjname.ttx" |
There was a problem hiding this comment.
We need to know why or if the %CD is necessary, otherwise it should be removed
There was a problem hiding this comment.
%cd% means “current directory”. @Tenrys said that some commands were ignoring the pushd, so they added the %cd%s accordingly.
They could probably explain more about how it didn't work in their case, and the “before and after” results of %cd% additions.
There was a problem hiding this comment.
Here are two screenshots to illustrate why I added usage of %CD%.
%CD% absent:
(Do note that ttx also fails, as can be seen by the first error message in the picture)
%CD% present:
I don't know if the fact that I am calling install.cmd from PowerShell has any incidence on it, but it should make it more reliable in that case if it does.
I was having a bunch of issues with the install script, and had to tweak the bat file a bit for my purposes, mainly because I was using pyenv for my Python versioning.
I had an issue where I had
pipandttxas.batfiles in the environment, not.exefiles, so they would make the script exit early after being called if not called withcall.Not entirely sure why I had to append
%CD%where I did, though, some commands were ignoring thepushdcommand above.I threw these changes rather hastily, so I'm putting them out here in order to discuss these sorts of issues and gather feedback, if there are any better solutions.