Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/audit changes #13

Merged
merged 10 commits into from
May 3, 2023
Merged

Bugfix/audit changes #13

merged 10 commits into from
May 3, 2023

Conversation

ruslangm
Copy link
Collaborator

@ruslangm ruslangm commented May 3, 2023

Description

  1. Added constraints for each transaction type in case it's flag is false to prevent an arbitrary assignment.
  2. Removed redundant code in merkle.go
  3. Reset the hFunc inside of VerifyEddsaSig, instead of reset it outside to make the code more clear.

Rationale

Audit related changes

@garyxiong123 garyxiong123 merged commit fd35ecc into 15000785133:qa May 3, 2023
@ruslangm ruslangm mentioned this pull request May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyxiong123 garyxiong123 garyxiong123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruslangm @garyxiong123