Validate Transaction Chain

15Dkatz · Sep 29, 2022 · d85179e · d85179e
1 parent 4d98221
commit d85179e
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/app/pubsub.js b/app/pubsub.js
@@ -29,7 +29,7 @@ class PubSub {
 
     switch(channel) {
       case CHANNELS.BLOCKCHAIN:
-        this.blockchain.replaceChain(parsedMessage, () => {
+        this.blockchain.replaceChain(parsedMessage, true, () => {
           this.transactionPool.clearBlockchainTransactions({
              chain: parsedMessage
           });

diff --git a/blockchain/index.js b/blockchain/index.js
@@ -18,7 +18,7 @@ class Blockchain {
     this.chain.push(newBlock);
   }
 
-  replaceChain(chain, onSuccess) {
+  replaceChain(chain, validateTransactions, onSuccess) {
     if (chain.length <= this.chain.length) {
       console.error('The incoming chain must be longer');
       return;
@@ -29,6 +29,11 @@ class Blockchain {
       return;
     }
 
+    if (validateTransactions && !this.validTransactionData({ chain })) {
+      console.error('The incoming chain has invalid data');
+      return;
+    }
+
     if (onSuccess) onSuccess();
     console.log('replacing chain with', chain);
     this.chain = chain;

diff --git a/blockchain/index.test.js b/blockchain/index.test.js
@@ -156,6 +156,19 @@ describe('Blockchain', () => {
         });
       });
     });
+
+    describe('and the `validateTransactions` flag is true', () => {
+      it('calls validateTransactionData()', () => {
+        const validateTransactionDataMock = jest.fn();
+
+        blockchain.validTransactionData = validateTransactionDataMock;
+
+        newChain.addBlock({ data: 'foo' });
+        blockchain.replaceChain(newChain.chain, true);
+
+        expect(validateTransactionDataMock).toHaveBeenCalled();
+      });
+    });
   });
 
   describe('validTransactionData()', () => {