Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to get the display's refresh rate #345

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add the ability to get the display's refresh rate #345

merged 1 commit into from
Mar 28, 2024

Conversation

fililip
Copy link
Contributor

@fililip fililip commented Mar 26, 2024

This might come in handy for frame timing calculations. Tested on Wayland and X11, works fine.

17cupsofcoffee
17cupsofcoffee approved these changes Mar 28, 2024
View reviewed changes
Copy link
Owner

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable thing to add! I did ponder for a little bit whether it'd be simpler to use PlatformError rather than create a new error variant, but given this is unlikely to be a fatal error it probably makes sense to split it out.

@17cupsofcoffee 17cupsofcoffee merged commit 66a5abf into 17cupsofcoffee:main Mar 28, 2024
3 checks passed
@17cupsofcoffee
Copy link
Owner

Thanks for the PR 🙂

@fililip fililip deleted the get-refresh-rate branch March 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fililip @17cupsofcoffee