Added some utility functions to animations and updated example #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Definitely interested in having this functionality, and I think the behaviors you've chosen (e.g. resetting when new frames are added) are probably the least surprising way it could work. One minor comment on a method name, but other than that I'm happy to take this as-is :)
|
I always end up doing that in my code and needing to refactor it afterwards, nasty habit. Fixed! |
examples/animation.rs
Outdated
| self.set_animation_2(); | ||
| } | ||
| if input::is_key_pressed(ctx, Key::Space) { | ||
| self.animation.restart_animation(); |
There was a problem hiding this comment.
You've still got the old method name here.
|
Derp, fixed |
|
Merged, thank you again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that
Animationdidn't have a way to update the animation when it's already configured.I've also updated the example. It now has the following buttons: