improve performance #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
40317ab 的提交是增加了性能测试以及程序正确性验证的程序 |
| @@ -72,21 +72,48 @@ public static void load(String filename, boolean strict) throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| private static int quickFindInIndexBuffer(long ip2long_value, int start, int end) { | |||
| while(true){ | |||
| int middle = (start + end) / 2; | |||
There was a problem hiding this comment.
不会 overflow，因为IP库里面的这个数组个数是有限制的，这不是一个通用的快速查找算法，不需要做溢出判断
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
耗时降低至原算法的 1/3 左右