Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accented characters like é causes the file to be corrupted #4

Open
sivanathan36 opened this issue Nov 29, 2019 · 4 comments
Open

Accented characters like é causes the file to be corrupted #4

sivanathan36 opened this issue Nov 29, 2019 · 4 comments

Comments

@sivanathan36
Copy link

sivanathan36 commented Nov 29, 2019

Issue or Feature Request

Issue Feature

Steps to reproduce

  1. Title field contains accented characters like é which corrupts the format of the aba file.

Expected Behaviour

See file: removed

Actual behaviour

See file: removed

Environment data and platform

Linux, docker, postgres

@17twenty
Copy link
Owner

Thanks for that @sivanathan36
The fix could be as simple as using asciiSafe(title) in the code to do a safe substitution as per a previous PR.

Reference: https://github.com/17twenty/aba/blob/master/aba.go#L54

Would you be able to put up and test a PR for that?

@sivanathan36
Copy link
Author

Thanks for that @sivanathan36
The fix could be as simple as using asciiSafe(title) in the code to do a safe substitution as per a previous PR.

Reference: https://github.com/17twenty/aba/blob/master/aba.go#L54

Would you be able to put up and test a PR for that?

@17twenty thanks for your replay. I think this doesn't solve the issue as it would replace the accented characters with an empty space as the characters do not fall inside the ASCII range. Ideally we would like to retain the accented characters.

@17twenty
Copy link
Owner

Hmm... ok, yeah, feel free to put up a PR. I'm just aware that it's required that they're ASCII characters. It's likely coming in as UTF and that's messing it up.

@17twenty
Copy link
Owner

@sivanathan36 I fixed it... mainly as I needed to start using it again. See how you go... wow, 2019!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants