Broken promise 😱; updated readme to add the new interaction

README.md

@@ -21,6 +21,9 @@ Charlie will exclaim about even more love, and will post in the #love channel
 `@charlie opm status`  
 Charlie will check with OPM about whether or not DC offices are open today
 
+`@charlie is <app> approved?`
+Charlie will check if the app is approved according to the [GSA IT Standards](https://ea.gsa.gov/#!/itstandards) (also [available on Github](https://github.com/GSA/data/blob/gh-pages/enterprise-architecture/it-standards.csv))
+
 `@charlie set tock <tock line>` or `@charlie set tock line <tock line>`  
 Charlie will associate the current channel to the given tock line
 

scripts/gsa-approved-software.js

@@ -54,25 +54,28 @@ const getMessage = (target) => {
   const lookingFor = target.toLowerCase();
   return getCSV().then(body => {
     const matches = [];
-    csv().fromString(body)
-      .on('csv', (item) => {
-        // Can't be certain the CSV is right, but we can at least
-        // make sure it has the right number of fields
-        if(item.length > 4 && item[0].toLowerCase().includes(lookingFor)) {
-          matches.push({ name: item[0], status: item[3], platform: item[4] })
-        }
-      }).on('done', () => {
-        let message = ''
-        if (matches.length == 0) {
-          message = `I didn't find anything in the GSA IT Standards for ${target}`;
-        } else if (matches.length <= 5) {
-          message = { attachments: matches.map(getAttachment) };
-          message.attachments[0].pretext = `Here's what I found in the GSA IT Standards`;
-        } else {
-          const finds = matches.map((item) => `*${item.name}* (${item.status})`)
-          message = `I found several potential matches for ${target}: ${finds.join(' | ')}`;
-        }
-        return message;
+
+    return new Promise((resolve, reject) => {
+      csv().fromString(body)
+        .on('csv', (item) => {
+          // Can't be certain the CSV is right, but we can at least
+          // make sure it has the right number of fields
+          if(item.length > 4 && item[0].toLowerCase().includes(lookingFor)) {
+            matches.push({ name: item[0], status: item[3], platform: item[4] })
+          }
+        }).on('done', () => {
+          let message = ''
+          if (matches.length == 0) {
+            message = `I didn't find anything in the GSA IT Standards for ${target}`;
+          } else if (matches.length <= 5) {
+            message = { attachments: matches.map(getAttachment) };
+            message.attachments[0].pretext = `Here's what I found in the GSA IT Standards`;
+          } else {
+            const finds = matches.map((item) => `*${item.name}* (${item.status})`)
+            message = `I found several potential matches for ${target}: ${finds.join(' | ')}`;
+          }
+          resolve(message);
+        }).on('error', err => reject(err));
       });
     });
 };