Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSA federated analytics #7

Closed
aaronsnow opened this issue Mar 7, 2014 · 12 comments
Closed

Add GSA federated analytics #7

aaronsnow opened this issue Mar 7, 2014 · 12 comments
Assignees
Labels

Comments

@aaronsnow
Copy link
Contributor

The page needs to include this file:
https://raw.github.com/GSA/DAP-Gov-wide-GA-Code/master/Federated-Analytics.js

@polastre
Copy link
Contributor

We're already using GSA's analytics.

@aaronsnow
Copy link
Contributor Author

All I see in the code is a standard Google Analytics snippet. That's not the same as the Federated Analytics script. Pretty sure we're supposed to use their full script.

@polastre
Copy link
Contributor

It all goes to the same place. Talk to @quepol; she's the one that has access to the Federated Analytics and said that we should use the code that's in there.

@aaronsnow
Copy link
Contributor Author

Ok thx. If @quepol is all over it, I'm good.

On Wed, Mar 12, 2014 at 10:34 AM, Joe Polastre notifications@github.comwrote:

It all goes to the same place. Talk to @quepol https://github.com/quepol;
she's the one that has access to the Federated Analytics and said that we
should use the code that's in there.

Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-37415091
.

@quepol
Copy link
Contributor

quepol commented Mar 17, 2014

Sorry, just now seeing this. 🐼
I created the Google Analytics snippet, but don't think it all goes to the same place. And holy heck that's a lot of javascript for analytics. Anyone know if we need all that? @aaronsnow?

I'll work on getting us all access to the Federated system.

@quepol quepol reopened this Mar 17, 2014
@polastre
Copy link
Contributor

Assigning to @quepol

@aaronsnow
Copy link
Contributor Author

I think belt-and-suspenders is best unless we're specifically instructed
otherwise. Let's include Federated-Analytics.js and also keep our own
snippet in there to retain easy access to our own analytics. Slightly
redundant but administratively simpler until/unless we get access to the
federated account. Thoughts?

On Mon, Mar 17, 2014 at 2:08 PM, Hillary Hartley
notifications@github.comwrote:

Sorry, just now seeing this. [image: 🐼]
I created the Google Analytics snippet, but don't think it all goes to the
same place. And holy heck that's a lot of javascript for analytics. Anyone
know if we need all that? @aaronsnow https://github.com/aaronsnow?

I'll work on getting us all access to the Federated system.

Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-37849939
.

@quepol
Copy link
Contributor

quepol commented Mar 18, 2014

Works for now. @polastre -- handoff to you to put the snippet where you deem appropriate?

@quepol quepol assigned polastre and unassigned quepol Mar 18, 2014
@polastre
Copy link
Contributor

This is your bug @quepol. Create a branch, put the code in you want, and propose it back in a pull request.

@polastre polastre assigned quepol and unassigned polastre Mar 18, 2014
@quepol
Copy link
Contributor

quepol commented Mar 18, 2014

Since we're now in launch mode, can someone else take this while I handle some of the other changes that have been requested? Thx. 💟

@amoose
Copy link
Contributor

amoose commented Mar 18, 2014

Added federated-analytics.js. Anything else?
-#23

amoose added a commit that referenced this issue Mar 18, 2014
@polastre
Copy link
Contributor

Fixed with #23. Closing

gemfarmer added a commit that referenced this issue Jan 18, 2017
# This is the 1st commit message:
accessibility for svgs and background images

# The commit message #2 will be skipped:

#	grid, accessibilty changes

# The commit message #3 will be skipped:

#	hound

# The commit message #4 will be skipped:

#	Styleguide

# The commit message #5 will be skipped:

#	copy tweaks and project template

# The commit message #6 will be skipped:

#	spacing

# The commit message #7 will be skipped:

#	box shadow
igorkorenfeld added a commit that referenced this issue Sep 20, 2023
Remove unused styles, layouts, options, and sitemap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants