Exposes _data/team.yml as publicly accessible JSON #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this idea, let's do it. I think it'd be better to use Jekyll's built in
|
|
+100 Please make sure we mention this on our /developer page. |
Now that's interesting. Looks like JekyllBot is abandoned, though. I bet we could create a pretty simple JSON content API ourselves with today's Jekyll, or through a Jekyll plugin? |
Closed
|
@gboone is this good to go? |
|
Well, it is in that it works (it generates something) but it generates an HTML file that has JSON in it. So, I don't think so, no. |
added 4 commits
October 15, 2014 14:53
Previous solutions have created json by using a page template. That's fine but actually generates an html file with json in the body. In addition to sending the data with the wrong content-type it also is rendered as html by browsers, javascript, etc., and would have required more maintenance for new data sets. This commit exposes an endpoint at `/api/<data>.json` for every dataset in the _data directory. For example, this site will have _data/team.yml exposed at `/api/team.json`
|
This should work now. Testing it locally I get valid JSON with the correct headers at |
meiqimichelle
added a commit
that referenced
this pull request
Oct 16, 2014
Exposes _data/team.yml as publicly accessible JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this will actually work (it should but my localhost webrick server was serving the generated file with
Content-Type: text/htmlinstead ofapplication/JSON) but this would expose the team member data we have in_dataas an api endpoint and allow us to access it in any of our other projects (like dashboard) as well as in javascript on the front end.Leaving this here for discussion.