Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Agile guide links #3777

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Update Agile guide links #3777

merged 3 commits into from
Nov 14, 2023

Conversation

eric-gade
Copy link
Contributor

Pull request summary

This PR updates the various links to the Agile guide to use the new URL/address (ie, from agile.18f.gov to guides.18f.gov/agile)

Reminder - please do the following before assigning reviewer

  • update readme
  • For frontend changes, ensure design review

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introdcued

Copy link
Member

@igorkorenfeld igorkorenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, the pa11y CI is still silently failing, as noted in #3773 , but that's unrelated to anything here.

@eric-gade
Copy link
Contributor Author

Sweet! I've only now merged the agile guide changes (which should make it live shortly). We should wait until that looks good before merging in this one.

Copy link
Contributor

@jskinne3 jskinne3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

-- What
Note that we only use the first three guides in the list. These are
the same guides that were manually put into this page prior to the commit.
@echappen echappen merged commit a449f9f into main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants