This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
[Delivers #92981132] move flash message below the header #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmc333333
added a commit
that referenced
this pull request
Apr 22, 2015
[Delivers #92981132] move flash message below the header
|
Looks good to me! Would it be helpful to add a close or hide X on the right side? Or is this not the kind of message that needs that? Also maybe make the dotted stroke a red/pink so that it blends a little more into the background? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious to hear @jehlers's opinion on it, but I think it's an improvement in terms of where there eyes will be on the page.