This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Extract Query objects from Reporter class #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jessieay
commented
Feb 5, 2016
jessieay
commented
- Part of https://trello.com/c/kBQy3z6F
jessieay
force-pushed
the
jy-sql-funtimes
branch
4 times, most recently
from
39529ec
to
524153e
Compare
|
argh this code climate error is due to duplication and I am not sure if / how best to fix. |
|
I like the code refactor here to split out the queries into their own classes. As far as going further to rewrite in raw SQL, I've commented on that Trello card that I don't consider it worth the effort. |
jessieay
force-pushed
the
jy-sql-funtimes
branch
from
524153e
to
f9e477e
Compare
|
@pkarman agreed. replied to your comment! |
jessieay
force-pushed
the
jy-sql-funtimes
branch
from
f9e477e
to
a82e3ec
Compare
* Cannot join on polymorphic
|
@jessieay test failures? I would ignore that code duplication error. It's not a duplicate. Methinks codeclimate algorithm needs some tweeking. |
|
@pkarman woops, should pass now. Agreed on duplication! |
pkarman
added a commit
that referenced
this pull request
Feb 5, 2016
Extract Query objects from Reporter class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.