Add agency name to report #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konklone
reviewed
Feb 24, 2017
| @@ -1,3 +1,4 @@ | |||
| # Agency for International Development | |||
| export ANALYTICS_REPORT_IDS="ga:68380943" | |||
| export AGENCY_NAME=agency-international-development | |||
| export AWS_BUCKET_PATH=data/agency-international-development | |||
There was a problem hiding this comment.
Why can't the analytics script itself read the AGENCY_NAME env var, instead of having it passed in on a new command line flag?
There was a problem hiding this comment.
Just moved things around so the name is pulled from the AGENCY_NAME env var.
jmhooper
commented
Mar 1, 2017
index.js
Outdated
| @@ -64,6 +64,8 @@ var run = function(options) { | |||
|
|
|||
| if (options.debug) console.log("[" + report.name + "] Saving report data..."); | |||
|
|
|||
| if (options.agency) data.agnecy = options.agency; | |||
jmhooper
force-pushed
the
jmhooper-agency-name
branch
from
8351668
to
56219c6
Compare
jmhooper
force-pushed
the
jmhooper-agency-name
branch
2 times, most recently
from
bc5fc9f
to
b9c8f9a
Compare
jmhooper
changed the title
konklone
reviewed
Mar 1, 2017
README.md
Outdated
| @@ -232,6 +232,12 @@ analytics --frequency=realtime | |||
| analytics --publish --debug | |||
| ``` | |||
|
|
|||
| * `--agency` - provide an agency name to associate with the report | |||
There was a problem hiding this comment.
Does the documentation also need to be updated to not use the --agency flag?
jmhooper
force-pushed
the
jmhooper-agency-name
branch
from
b9c8f9a
to
88607c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command adds an option for specifying an agency in the CLI options. This allows the name of the agency the data is being pulled for to be included in the final report, and in the data that is written to the database.
Ref #194
Hold for #197