-
Notifications
You must be signed in to change notification settings - Fork 191
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE section of browsers chart is rendering improperly #765
Comments
Thanks to @ryanhofdotgov, we have this info: Since IE doesn’t exist in the Browser section, this logic doesn’t work. Normally it would render as a sub-chart. Who would have thought we would live in a world where IE usage falls off the chart? The offending line of code is really this one: Line 89 in 92fe548
Needs to check if the Internet Explorer Key exists in the parent chart before nesting it. Technically also needs to be done with all the other nested charts. |
It appears the the Internet Explorer details are rendered all the time. However, here, "Internet Explorer" is not showing in the "Browsers" element, so the Internet Explorer element doesn't get nested, as intended. |
Here's a PR #767 The javascript line is perhaps overly cautious, and certainly ugly. But the general take here is to render AND hide the Internet Explorer section by default. And if the Browser section shows an "Internet Explorer" entry, the hidden section will show and be nested. If an entry for IE does not show, the original section will remain hidden. |
Closing as the IE sub section of the browsers chart has been removed |
What kind of issue?
In the https://analytics.usa.gov/executive-office-president/ and https://analytics.usa.gov/national-aeronautics-space-administration/, the Internet Explorer part of the Browsers chart is rendering as its own separate chart, with "Internet Explorer" in bold, and not representing a total percentage rather than just the % of IE versions. It should be a nested chart within the "Browsers" section.
The text was updated successfully, but these errors were encountered: