Fix link interpolation in invite fallback #1166
Conversation
static_src/components/users.jsx
Outdated
| return ( | ||
| <PanelDocumentation> | ||
| {`Currently, only an org manager can invite users to this ${this.entityType} | ||
| Currently, only an org manager can invite users to this { this.entityType } | ||
| via the dashboard. If the user you want to add is already a cloud.gov member, |
There was a problem hiding this comment.
is already a cloud.gov member - > is already a member of the organization
There was a problem hiding this comment.
not necessary but it would be helpful if we could inject the actual name of the organization so it would be is already a member of the "test" organization (given the current org is test)
static_src/components/users.jsx
Outdated
| you can invite them using the <a href=${cfAPILink}>cloud foundry api. </a> | ||
| Speak to your org manager if you need to add a user to this ${this.entityType} who | ||
| is not a member of cloud.gov`} | ||
| you can invite them using the <a href={ cfAPILink }>cloud foundry api. </a> |
There was a problem hiding this comment.
cfAPILink -> CF_CLI_SPACE_ROLE_LINK
There was a problem hiding this comment.
cloud foundry api -> Cloud Foundry CLI to assign a Space Role to the user
static_src/components/users.jsx
Outdated
| @@ -23,6 +23,7 @@ const ORG_MANAGER = 'org_manager'; | |||
| const SPACE_MANAGER = 'space_manager'; | |||
| const ORG_ENTITY = 'organization'; | |||
| const SPACE_ENTITY = 'space'; | |||
| const cfAPILink = 'https://cloud.gov/docs/getting-started/setup/#set-up-the-command-line'; | |||
There was a problem hiding this comment.
let's change this to https://docs.cloudfoundry.org/adminguide/cli-user-management.html#space-roles
There was a problem hiding this comment.
cfAPILink -> CF_CLI_SPACE_ROLE_LINK
static_src/components/users.jsx
Outdated
| is not a member of cloud.gov`} | ||
| you can invite them using the <a href={ cfAPILink }>cloud foundry api. </a> | ||
| Speak to your org manager if you need to add a user to this { this.entityType } who | ||
| is not a member of cloud.gov |
There was a problem hiding this comment.
of cloud.gov -> of the organization
There was a problem hiding this comment.
not necessary but it would be helpful if we could inject the actual name of the organization so it would be of the "test" organization (given the current org is test)
static_src/components/users.jsx
Outdated
| Speak to your org manager if you need to add a user to this ${this.entityType} who | ||
| is not a member of cloud.gov`} | ||
| you can invite them using the <a href={ cfAPILink }>cloud foundry api. </a> | ||
| Speak to your org manager if you need to add a user to this { this.entityType } who |
There was a problem hiding this comment.
Speak to your -> Speak to an (there can be multiple org managers)
|
@jcscottiii Updated! |
el-mapache
force-pushed
the
ab-fix-link-interpolation
branch
from
a680afc
to
4d8e9ef
Compare
el-mapache
force-pushed
the
ab-fix-link-interpolation
branch
from
4d8e9ef
to
f1b53d0
Compare
|
new screenshot |
Link now correctly renders!
screenshot:
