This repository has been archived by the owner on May 19, 2020. It is now read-only.
Fixed route and other error handling #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this should be applied globally to all the errors. The |
A change, maybe in axios ajax module, maybe somewhere else changed the error responses so the actual data resides in a `response` object within the error object. This was breaking the error catching. The fix is the pass the error `response` object to the `handleError` function so the correct data is supplied to it so it can pass the error correctly to the UI with the correct information.
msecret
force-pushed
the
ms-fix_route_error_handling
branch
from
03e63a2
to
0830624
Compare
The CF API should now use the new axios error format of having the error data nested in the `response` object. Also changes the naming convention of this fake error in an attempt to make it more clear what it is in the tests. Only modified this where the tests were failing. I also added a catch to promises in the cf api code, to ensure that when a piece of code failed in the error or other handlers, it wouldn't time out but would provide a good error message to the developer testing.
adborden
approved these changes
Jan 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change, maybe in axios ajax module, maybe somewhere else changed
the error responses so the actual data resides in a
responseobjectwithin the error object. This was breaking the error catching. The
fix is the pass the error
responseobject to thehandleErrorfunction so the correct data is supplied to it so it can pass the
error correctly to the UI with the correct information.
Additionally, the route store wasn't resetting the route loading state after
and error, which was causing the editing loading text to appear after any
error.
Ref #915