This repository has been archived by the owner on May 19, 2020. It is now read-only.
Pre launch fix acceptance tests #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The login required to click an authorize button on first try, not sure why this didn't come up before. May need an if statement in case the authroize button isn't there at all meaning it's not required to be clicked.
…-fix_acceptance_tests
…-fix_acceptance_tests
… into pre_launch-fix_acceptance_tests
The tests should not have: Eventually(Expect(..).To()) Basically it should either use Eventually or Expect not both Instead, it should use: Eventually(sel).Should(matcher())
Pre launch fix acceptance tests
Added more classes to make things easily selectable in the tests Fixed an error in the API where it was using the wrong url
The phantomjs driver should be used in CI settings. Ideally we should configure this with an env var so that devs can keep using Chrome, as it's much easier to diagnose problems.
Newer versions of karma have an unfixed bug: karma-runner/karma#1782 Should set to upgrade patch versions automatically after its fixed.
This goes along with changes to the actually repos.
It might also need password, can't tell because of security
jcscottiii
added a commit
that referenced
this pull request
Jan 7, 2016
Pre launch fix acceptance tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets the relevant acceptance tests working again. I left out the routes and app tests as I haven't built those pages yet. Everything else is running.
There's currently an issue with the tests I haven't figured out yet: #159