-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sockets.forEach is not a function #1782
sockets.forEach is not a function #1782
Comments
Same here, even my previous passing tests are all failing because of this after a node modules reinstall. |
Thanks for the report, can you please check on the latest version and create a small repo that reproducea this error or point me to your project if it's open source? |
@dignifiedquire We got the same issue in our project. Just take a look at Travis in the bottom: Seems to run into a infinity loop just now. Going to downgrade for now until this is sorted out. Code that fails is this:
|
I tried downgrading and even then I have the same error, was using chrome launcher with karma-mocha if it helps.. |
Newer versions of karma have an unfixed bug: karma-runner/karma#1782 Should set to upgrade patch versions automatically after its fixed.
This is due to socket.io bumping to 1.4.0. 1.3.7 worked just fine. We are having this problem too and it is causing our CI to fail. |
Does 0.13.15 work? |
All newer 0.13 releases seem to be broken, as there seems to be some breaking change in socket.io@1.4.0 |
The issues is in package.json for karma: "socket.io": "^1.3.7", and 1.4.0 matches this (at least http://jubianchi.github.io/semver-check/ says so...) |
Yes, but breaking backwards compatible changes should only be happening in major bumps, not minor version increases. So the semver range specified is fine in that regard. |
Is this the problem? |
@pushups probably |
As a workaround try setting this in your package.json. Meaning not in karmas package.json in your own which is the one requiring karma. |
0.13.9 should have socket.io dependency: |
Just tried karma@0.13.9 and it worked. |
Confirming karma@0.13.9 works! Anything above it will match socket.io 1.4.0. |
Patch incoming |
Just published |
Do you mean 19? |
yes |
OK :D thanks for the fast work! 👏 |
Yes! Thanks for the quick turn around! |
+1 thanks alot! |
socket.io released backwards incompatible API changes in a minor version update, causing failures during our ui-tests travis run. See: socketio/socket.io#2368 However the latest version of Karma has added support for it: karma-runner/karma#1782
I change the version directly on package.json is that right?? |
I succeed!!!! |
…arma#1782 Päivitetty karma versioon 0.13.19 vinkkien perusteella.
socket.io made recent breaking changes to their internals that older versions of karma uses (See karma-runner/karma#1782). The old bug with newer karma versions has disappeared and is assumed fixed (See 817ea3d). Change-Id: Id1efa635de34f3d864c51c784b2343b8c9d9adee
Fixes error with socket.io mentioned in issue karma-runner/karma#1782
Fixes error with socket.io mentioned in issue karma-runner/karma#1782
…arma#1782 Päivitetty karma versioon 0.13.19 vinkkien perusteella.
I seem to still have this problem with the latest version of Karma:
Any idea what it could be? Tried downgrading to .19, but I had the same problem. |
Yep I'm seeing it once again too. |
Yeah, I'm seeing a very similar issue to this. Here are the details: http://stackoverflow.com/questions/35952704/karma-move-folder-missing-error-handler-on-socket |
These are different issue, the error message is just similar. Please file separate issues |
This commit also updates karam to 0.13.22 to avoid karma-runner/karma#1782 (sockets.forEach is not a function) when running gulp test.
This commit also updates karam to 0.13.22 to avoid karma-runner/karma#1782 (sockets.forEach is not a function) when running gulp test.
This commit also updates karam to 0.13.22 to avoid karma-runner/karma#1782 (sockets.forEach is not a function) when running gulp test.
This commit also updates karam to 0.13.22 to avoid karma-runner/karma#1782 (sockets.forEach is not a function) when running gulp test.
This commit also updates karam to 0.13.22 to avoid karma-runner/karma#1782 (sockets.forEach is not a function) when running gulp test.
* Do not merge the same story. * Actually handle replacing, not merging, records. * Try to replace tapes, when possible. * Search UI will handle dates for queries. * Pasing the correct parameters to the service for search. * Search client service, not exporting unnecessary things. * Chore: removing extra whitespace. * Fix database not being read at startup * Some layout improvements, breaking start and end dates into explicit fields that can be manually set by the user. * Add some basic logging on error * Some layout improvements, breaking start and end dates into explicit fields that can be manually set by the user. * Expand first/last dates. * Current record will collapse on background click. * Adding a new record will set it as current for editing. * Fixing collapse when middle record is selected. * Add icon indicators on right side. * Tests for archive.collapse * Remove extension importing mock logger. * Gulpfile makes builds *much* faster. * Gulp for build; run mocha and karma directly. * Save on close, and show toast when done. * Made webpack less verbose in it's output, took out webpack stream. * Updated mocks. * Add multimedia to detail view layout - Adds videos, images, and notes to layout. - Adds videos and images to the data model. * Don't let stubs span columns * Fix some nits. * Add file upload UI and API route * Reused TabletTop uploader. * Uploads save in data/ directory, and load in sidebar. * Updates after call w/ Stan * Ensure persisted database when no db present. * Only show image loader with valid label. * Miscellaneous. * Cleaned up date entry. * Reload data when loading records. * Added missing static mock. * When renaming a record, move the images as well. * Sort by label when find()ing all records. * Test regression and correctly filter duplicate stories. * Add static Bootstrap, and augment some elements with bootstrap styles. * Bump karma version, see karma-runner/karma#1782 * Records now grouped by family * Futzed with styles for archive record list. * Use same markup in pre and post. * no-sticky the subheaders. * Add toggle between view and edit for record top content. * Responsive record view * Initial markup for video association. * This tweaks a bug with firefox's rendering of md-card. Basically, there is a css prop that sets max height to 100%. Firefox interprets this as the height of the visible viewport rather than 'what is needed', or whatever chrome actually is. By setting this value to inherit, the height is automatically inherited. This works in chrome and firefox. * Added videos api, and /api/videos/incoming route. * Tweak class implementation. * Patch the other card. * worked in video player to responsive design and moved buttons * put back real video code * Changes to labels. Dates crunch and family as a super. * Hey tests actually run now. * So, apparently <super> isn't a tag. Changed to <sup> and added md-subheader class to family on record view. * displays error when server not running * Tigthen list view and fix icons * Changed icon for notes * Fix tests that had bad form, and add Associate route for adding vidoes. * Displaying incoming videos. * Associate incoming videos. * When creating a new record, start in edit state. * Added documentation on how to set up ./incoming * Do not try to focus a record when it does not have an input. * Added image delete button. * Search bar works and even works right! * Allow force set of a Record id * Correct test to use ID convention forced in Record * Set baseId when id is force set; Update test to check for force set id * Remove tslint option * Fix a bunch of breaking things. * Add a form-level action for searching. * Unify data/ and incoming/ * Update docs. * Try ARCHIVE_DATA_ROOT first for image paths. * And do the same for the list of incoming vidoes. * finish refactoring basePath and dataPath. * Moving in a hurry... * Added debugging for video display. * Use more correct images url for video. * Remove console.log * Changes to adding video * Don't attempt to save when a current request is in flight. * Make Notes part of the Editable toggle. * Add videos safely, and show them immediately. * This makes the style bar look not as totally horendous. * Create missing record folders when associating videos. * When users attempt to move a record into an existing label, don't damage data and tell them why it failed. * Ensure newly added & saved records have correct baseId. * URL encodes search and selected record. BIG BUG: Dates are all mucked up. * Fix date handling. * Handle all path permutations. * Records have a more permissive check for when two stories are equivalent. * Clarified and simplified story adding and editing. * Save record when finished editing stories. * Do not dupe when saving renamed stories. * Only allow single story to be edited at a time. * Clearing a story's slug will change save to delete. * Sets focus on slug when editing story. * Merge with a real record. * Search within stories. * Wait for previous record to close before opening new record. * Delete button on images confirms, then deletes. * Sort by family, then first: date. * Punt on performance, and just hide the FAB when a tape is selected. * Use mdButton for virtual click on Add Image. * Delete dialog and button. * Update media links when renaming records. * Always anchorscroll when selecting records. * Apparently we were not merging dates, because we thought they should be computed at one point. * Consistently enters edit mode when creating a new record. * Assume that returned media data is canonical. * Update location when saving and when collapsing. * Return record data after renaming files, and update in memory record. * Turns out, failing to remove an image you want removed is not an exceptional case. * Delete records, as per discussion. * Actually remove the tape after deleting it. * Remove the empty directory on delete. * Make viewing state for notes * add padding to video player * put record medium selector in line * Disable [Delete] when the form is not pristine. * Do not fail save when data/id dir is not present. * addressed Davids notes * a space * another space
I input 'npm install socket.io@1.3.5 --save' in command |
Running karma 0.13.16 I encountered the following issue after the last test run successfully:
I didn't make any changes to the code or to the test itself but reinstalled the node_modules.
The text was updated successfully, but these errors were encountered: