Skip to content
This repository has been archived by the owner on Dec 8, 2017. It is now read-only.

Code links on front page link to github.com instead of github project page #331

Closed
ArcTanSusan opened this issue Jan 3, 2016 · 1 comment
Assignees

Comments

@ArcTanSusan
Copy link

Hover over code links and you'll see they link to www.github.com homepage instead of the specific 18F project source code page on github.

@gboone
Copy link
Contributor

gboone commented Jan 5, 2016

Thanks for the issue, @onceuponatimeforever. Upon further investigation, this seems to be the case only if the project's data file doesn't have a GitHub section. For example, Every Kid in a Park has a github entry and it's listing on the Dashboard and project page both show a link to the listed repo. USCIS doesn't have one and it's listing in the Dashboard shows this bug.

DavidEBest pushed a commit that referenced this issue Jan 5, 2016
Previously, the index page would include `code` links for all projects, even if they do not define a github repo. This adds a check for the value, and if absent, does not show the (bogus) info.

Fixes #331
@DavidEBest DavidEBest self-assigned this Jan 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants