Update webpack #2186

gemfarmer · 2017-01-10T16:22:35Z

Fixes issue(s) build issues on #2185

Changes proposed in this pull request:

creates npm script to update all webpack-generated files and output new sourcemaps. This should address the dependency issue we were seeing in Dev --> staging #2185, where all node packages had been updated, but new source maps hadn't been created to reference those updates.
updated the circle.yml config to run dependencies and build processes in the proper order
updated the circle.yml config to run the new update-webpack command.

houndci-bot · 2017-01-10T16:22:43Z

js/lib/main.js

+	            }
+	            mapping.originalLine = original.line;
+	            mapping.originalColumn = original.column;
+	            if (original.name != null) {


Use '!==' to compare with 'null'.
Too many errors. (10% scanned).

houndci-bot · 2017-01-10T16:22:43Z

js/lib/main.js

+	            if (aSourceMapPath != null) {
+	              mapping.source = util.join(aSourceMapPath, mapping.source)
+	            }
+	            if (sourceRoot != null) {


Use '!==' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:43Z

js/lib/main.js

+	            // Copy mapping
+	            mapping.source = original.source;
+	            if (aSourceMapPath != null) {
+	              mapping.source = util.join(aSourceMapPath, mapping.source)


Missing semicolon.

houndci-bot · 2017-01-10T16:22:44Z

js/lib/main.js

+	          if (original.source != null) {
+	            // Copy mapping
+	            mapping.source = original.source;
+	            if (aSourceMapPath != null) {


Use '!==' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:44Z

js/lib/main.js

+	            line: mapping.originalLine,
+	            column: mapping.originalColumn
+	          });
+	          if (original.source != null) {


Use '!==' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:44Z

js/lib/main.js

+	      // Find mappings for the "sourceFile"
+	      this._mappings.unsortedForEach(function (mapping) {
+	        if (mapping.source === sourceFile && mapping.originalLine != null) {
+	          // Check if it can be mapped by the source map, then update the mapping.


Line is too long.

houndci-bot · 2017-01-10T16:22:44Z

js/lib/main.js

+
+	      // Find mappings for the "sourceFile"
+	      this._mappings.unsortedForEach(function (mapping) {
+	        if (mapping.source === sourceFile && mapping.originalLine != null) {


Use '!==' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:45Z

js/lib/main.js

+	      if (sourceRoot != null) {
+	        sourceFile = util.relative(sourceRoot, sourceFile);
+	      }
+	      // Applying the SourceMap can add and remove items from the sources and


Line is too long.

houndci-bot · 2017-01-10T16:22:45Z

js/lib/main.js

+	      }
+	      var sourceRoot = this._sourceRoot;
+	      // Make "sourceFile" relative if an absolute Url is passed.
+	      if (sourceRoot != null) {


Use '!==' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:45Z

js/lib/main.js

+	        if (aSourceMapConsumer.file == null) {
+	          throw new Error(
+	            'SourceMapGenerator.prototype.applySourceMap requires either an explicit source file, ' +
+	            'or the source map\'s "file" property. Both were omitted.'


Mixed double and single quotes.

houndci-bot · 2017-01-10T16:22:46Z

js/lib/main.js

+	      if (aSourceFile == null) {
+	        if (aSourceMapConsumer.file == null) {
+	          throw new Error(
+	            'SourceMapGenerator.prototype.applySourceMap requires either an explicit source file, ' +


Line is too long.
Mixed double and single quotes.

houndci-bot · 2017-01-10T16:22:46Z

js/lib/main.js

+	      var sourceFile = aSourceFile;
+	      // If aSourceFile is omitted, we will use the file property of the SourceMap
+	      if (aSourceFile == null) {
+	        if (aSourceMapConsumer.file == null) {


Use '===' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:46Z

js/lib/main.js

+	    function SourceMapGenerator_applySourceMap(aSourceMapConsumer, aSourceFile, aSourceMapPath) {
+	      var sourceFile = aSourceFile;
+	      // If aSourceFile is omitted, we will use the file property of the SourceMap
+	      if (aSourceFile == null) {


Use '===' to compare with 'null'.

houndci-bot · 2017-01-10T16:22:47Z

js/lib/main.js

+	  SourceMapGenerator.prototype.applySourceMap =
+	    function SourceMapGenerator_applySourceMap(aSourceMapConsumer, aSourceFile, aSourceMapPath) {
+	      var sourceFile = aSourceFile;
+	      // If aSourceFile is omitted, we will use the file property of the SourceMap


Line is too long.

houndci-bot · 2017-01-10T16:22:47Z

js/lib/main.js

+	   *        relative to the SourceMapGenerator.
+	   */
+	  SourceMapGenerator.prototype.applySourceMap =
+	    function SourceMapGenerator_applySourceMap(aSourceMapConsumer, aSourceFile, aSourceMapPath) {


Line is too long.

houndci-bot · 2017-01-10T16:22:47Z

js/lib/main.js

+	   * @param aSourceMapPath Optional. The dirname of the path to the source map
+	   *        to be applied. If relative, it is relative to the SourceMapConsumer.
+	   *        This parameter is needed when the two source maps aren't in the same
+	   *        directory, and the source map to be applied contains relative source


Line is too long.

gemfarmer · 2017-01-10T16:28:12Z

~~@meiqimichelle all these hound errors are auto-generated by webpack, so it is a bit out of our control.~~

Scratch that. I was just being lazy. I ignored the autofiles from being linted with e465ba5.

gemfarmer · 2017-01-10T16:48:31Z

@meiqimichelle so this is still failing, but in a different way. The site runs fine locally and forums suggest that the build error we are getting now on Circle will be intermittent. I'm going to put this on hold and try to rebuild it later.

gemfarmer · 2017-01-12T15:51:06Z

@meiqimichelle I reviewed this again, and it has my stamp of approval to merge. @shawnbot, what do you think?

shawnbot

👍 LGTM!

gemfarmer · 2017-01-12T18:30:04Z

Cool!

gemfarmer added the workflow:testing label Jan 10, 2017

houndci-bot reviewed Jan 10, 2017

View reviewed changes

gemfarmer force-pushed the node-dependencies branch from edd3c58 to bea03db Compare January 10, 2017 16:46

gemfarmer force-pushed the node-dependencies branch from 0985b9f to 3170f14 Compare January 10, 2017 22:32

update webpack, create command to update webpack and run in ci

da5a914

gemfarmer force-pushed the node-dependencies branch from 3170f14 to da5a914 Compare January 10, 2017 22:39

gemfarmer mentioned this pull request Jan 12, 2017

[wip] webpack #2187

Closed

shawnbot approved these changes Jan 12, 2017

View reviewed changes

gemfarmer merged commit f7b3d10 into dev Jan 12, 2017

gemfarmer removed the workflow:testing label Jan 12, 2017

gemfarmer deleted the node-dependencies branch January 12, 2017 18:30

This was referenced Feb 8, 2017

dev --> staging #2202

Merged

Staging --> master v2.1.6 #2204

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update webpack #2186

Update webpack #2186

gemfarmer commented Jan 10, 2017 •

edited

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

houndci-bot Jan 10, 2017

gemfarmer commented Jan 10, 2017 •

edited

gemfarmer commented Jan 10, 2017

gemfarmer commented Jan 12, 2017

shawnbot left a comment

gemfarmer commented Jan 12, 2017

Update webpack #2186

Update webpack #2186

Conversation

gemfarmer commented Jan 10, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gemfarmer commented Jan 10, 2017 • edited

gemfarmer commented Jan 10, 2017

gemfarmer commented Jan 12, 2017

shawnbot left a comment

Choose a reason for hiding this comment

gemfarmer commented Jan 12, 2017

gemfarmer commented Jan 10, 2017 •

edited

gemfarmer commented Jan 10, 2017 •

edited