This repository has been archived by the owner on Dec 17, 2021. It is now read-only.
Local timeout that kills sslyze scans -- but doesn't clean up processes #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #138, that adds a local timeout library that successfully cuts off sslyze processes that get zombified for unknown reasons.
The full solution is to migrate our use of sslyze to the Python API, now that sslyze works on Python 3 and has such an API. This would also help us track down the source of the hangup in a more granular way, as opposed to the process being a black box.
We'd likely still also benefit from this work on a local timeout, and it could be useful for other scanners, so this seems worth doing.