Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

Local timeout that kills sslyze scans -- but doesn't clean up processes #150

Closed
wants to merge 2 commits into from

Conversation

konklone
Copy link
Contributor

This is a partial fix for #138, that adds a local timeout library that successfully cuts off sslyze processes that get zombified for unknown reasons.

The full solution is to migrate our use of sslyze to the Python API, now that sslyze works on Python 3 and has such an API. This would also help us track down the source of the hangup in a more granular way, as opposed to the process being a black box.

We'd likely still also benefit from this work on a local timeout, and it could be useful for other scanners, so this seems worth doing.

@konklone
Copy link
Contributor Author

To make this more explicit: if sslyze processes get zombied, I believe they may end up needing a manual kill sweep to clean them up, but the scan can continue. That's why this is only partial.

@konklone
Copy link
Contributor Author

konklone commented Nov 1, 2017

Closed in favor of #151.

@konklone konklone closed this Nov 1, 2017
@konklone konklone deleted the force-timeout branch November 9, 2017 06:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant