This repository has been archived by the owner on Dec 17, 2021. It is now read-only.
Sync up with site-inspector refactor #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konklone
added a commit
that referenced
this pull request
Apr 23, 2015
Sync up with site-inspector refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syncs up with the major output changes of benbalter/site-inspector#24 that define a new, more granular
--httpmode. That mode may becomesite-inspector's new default at some point, but until then we'll count on passing--httptosite-inspector.This also allows the caller to override the command that calls
site-inspector.This was added because when runningsite-inspectorlocally as an installed gem,rbenvappeared to add substantial overhead to each execution ofsite-inspector, something like 200-300ms, for each domain. So ifsite-inspectoris checked out locally, the command can be overridden to point to the local instance to save time on large batch operations.