In order to have consistent and easy-to-implement alerts, define alert icon styles #158
Comments
I like it. I can implement this. |
Cool! I have the images ready: (the last three are white on white, but you get the idea!) Do these names make sense? |
I'm just popping on to say how impressively fast you iterated on this! Go On Fri, Oct 23, 2015 at 1:07 PM, Jennifer Thibault <notifications@github.com
|
Sounds good on the info. For naming scheme, because we're only dealing with either blue or white ones, and the blue ones are default, i just went with:
And then the white ones are: These changes are all made in the updating-icons branch. |
Closed by #157 |
@noahmanger 's keen eye in #157 pointed out a new pattern in alerts that we had not designed for: how alerts and alert icons look on colored backgrounds that may change color.
This meant we needed to take another look at the alert system as a whole, and tinker a bit.
To that point, the alert designs had looked like this:
But we needed to flesh out the system to accommodate colored backgrounds as well, while keeping the number of unique styles to a minimum so that the easiest design to implement will be the best design. Here's an approach I'd like to try:
border-left
instead ofborder-top
, and make it a bit heavier (3px?). The color keeps it bright and makes it a bit more friendly.This makes for only two style variances—one for neutral backgrounds, one for primary and secondary backgrounds:
Those would come together to look like these:
The text was updated successfully, but these errors were encountered: