This repository has been archived by the owner on Dec 3, 2017. It is now read-only.
Adjusting alert documentation #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 77.37% (diff: 100%)@@ master #529 diff @@
==========================================
Files 27 27
Lines 1366 1366
Methods 230 230
Messages 0 0
Branches 193 193
==========================================
Hits 1057 1057
Misses 309 309
Partials 0 0
|
added 2 commits
September 30, 2016 18:21
Helps users choose between alert messages.
|
Update! Thanks to a great explainer session with @noahmanger the style guide is now updated with helpful example text for each message type, and some basic documentation on when to use each. Review
|
jenniferthibault
changed the title
|
Content here looks great, Jen. Thanks! |
|
Looks good. I just moved the docs to a .hbs file so it's easier to read. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While I was looking for example patterns for fecgov/openFEC-web-app#1598 I looked back to our pattern design work in #266 (comment) and noticed that some left-hand spacing was missing from
no-iconmessage styles. This adds the padding.Remaining tasks:
I'm also having a hard time getting the style guide to update locally, and would love some help from @noahmanger so that I can learn how to do this! The screenshot below is from adjusting the space through the browser inspector.
Screenshots