Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🟡 Update with information related to Crypto #325

Open
Tracked by #385 ...
its-a-lisa-at-work opened this issue Oct 21, 2021 · 2 comments
Open
Tracked by #385 ...

🟡 Update with information related to Crypto #325

its-a-lisa-at-work opened this issue Oct 21, 2021 · 2 comments
Labels
Engineering Task related to the Engineering Guide and/or pulled from the old Engineering Guide repo. Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"

Comments

@its-a-lisa-at-work
Copy link

This is a really good example from @mgwalker on an implementation he did for crypto https://github.com/CMSgov/eAPD/pull/1514/files#diff-fa6796d6a6e8c4c9fc59e6f2b82f1b6cdec0a58af443f16beb73ecb567e9af9a

I found it because I'm going through a similar experience where I'm examining some code's crypto https://gsa-tts.slack.com/archives/C02DYG8UK6E/p1634836139002600 and searching I saw another instance where bcrypt was mentioned https://gsa-tts.slack.com/archives/C8E5EJK9V/p1558377372059400 and reached out to Greg to chat about it and he let me know that the repo had moved Enterprise-CMCS/eAPD#1514 and pointed out the good example above!

User Story:
As a developer that is new to government engineering, I would like to know up front that bcrypt shouldn't be used and pbkdf2 should be used instead so that I can create code that is FIPS-140 compliant.

@echappen
Copy link
Contributor

@its-a-lisa-at-work Thanks for bringing this up. It seems like this topic could warrant its own new page under the Security section called "Cryptography Approaches" (or something like that). Unless you see a current page in the guide that it could be added to.

As someone new to government engineering myself, I think a page like this could help me think through all the factors to consider when I'm faced with a need for a cryptographic solution. Like: what is FIPS-140? Why should I follow it? What other standards should I consider, if any? What would be must-haves vs nice-to-haves in a crypto solution in a government context? I'm sure there are other questions that could be answered here too that I'm not thinking of.

Would you or @mgwalker be able/willing to draft a page like that? And if not, could you point me in the direction of good people to ask?

@Krish-bhardwaj

This comment has been minimized.

@christophermather christophermather transferred this issue from 18F/development-guide Dec 20, 2023
@christophermather christophermather added the Engineering Task related to the Engineering Guide and/or pulled from the old Engineering Guide repo. label Dec 20, 2023
@christophermather christophermather added Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods" Guides labels Dec 22, 2023
@amymok amymok changed the title Update with information related to Crypto 🟡 Update with information related to Crypto Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Task related to the Engineering Guide and/or pulled from the old Engineering Guide repo. Guides Initiative 2 Tracks work for "Improving the Maintainability of the 18F Guides and Methods"
Projects
None yet
Development

No branches or pull requests

4 participants