Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reference to the laptop script #2186

Merged
merged 2 commits into from
Oct 21, 2020
Merged

remove reference to the laptop script #2186

merged 2 commits into from
Oct 21, 2020

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Oct 19, 2020

The laptop script has been long un[der]maintained, and I think has been completely broken for at least a year. This is taking the proposal from 18F/laptop#189 a step further: since there's no ability to maintain it (right now), we should stop confusing new hires and take it out of the onboarding steps.

Side note: preventing committing secrets is the part of the script that I do believe should be a requirement for anyone interacting with Git. I am talking with the Mac Working Group about having that on our Macs by default. This is a much better way to ensure consistency. cc 18F/laptop#185

If you agree with this change, please leave a 馃憤 emoji vote. If you disagree, please leave a comment, or send me a message on Slack. I'll wait to merge until it seems there is consensus. Thanks!

Follow-up TODOs

@afeld afeld added this to Reviewed Required in TTS Tech Portfolio (Pull Requests) via automation Oct 19, 2020
@Sgtpluck
Copy link
Member

I wonder if there's value in leaving a reference to it for developers who don't have mature dotfiles/want to see how others have set up their computers in the past?

I just onboarded and while I didn't end up using the laptop script, I did look through it to see if there was anything configuration or software in particular that was preferred, and thought it was nice to look through!

@its-a-lisa-at-work
Copy link
Contributor

I added some other folks that have either made comments within Slack or GitHub Issues/Pull Requests in the last year to make sure they have visibility into this as well. I noticed not all of them have given the 馃憤 so given them a chance to also give a 馃憥 or leave a comment.

@mgwalker
Copy link
Member

@Sgtpluck That's a really good point. We should capture those recommendations and get them into the handbook or the engineering guide. I think things like a preference for environment/version manager (nvm vs. n, or chruby vs. rbenv, for example) are prime candidates for the engineering guide.

@afeld
Copy link
Contributor Author

afeld commented Oct 21, 2020

Not hearing any objections, going to go ahead and merge this. If someone wants to incorporate recommendations into the Engineering Guide, by all means!

@afeld afeld merged commit bf6d6e0 into master Oct 21, 2020
TTS Tech Portfolio (Pull Requests) automation moved this from Reviewed Required to Done Oct 21, 2020
@afeld afeld deleted the no-laptop-script branch October 21, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants