This repository has been archived by the owner on Dec 8, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Commits on Dec 13, 2014
-
Hide SSI auth include directive in public mode
Mike Bland committedDec 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 95193a4 - Browse repository at this point
Copy the full SHA 95193a4View commit details -
Convert joiner_test.rb to Minitest
Mike Bland committedDec 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 953bbd2 - Browse repository at this point
Copy the full SHA 953bbd2View commit details -
Import guest users from _data/private/hub
This data will be used to generate authentication artifacts for users outside the team.
Mike Bland committedDec 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 385480e - Browse repository at this point
Copy the full SHA 385480eView commit details -
Move DummyTestPage into separate module
Mike Bland committedDec 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 64371f0 - Browse repository at this point
Copy the full SHA 64371f0View commit details -
Generate auth artifacts for guest users
This enables users in the _data/private/hub/guest_users.yml list to access the Hub. Authenication includes are generated, but do not link to any pages. On top of being a nice touch, they're necessary to avoid breaking the Server Side Include directive in _layouts/bare.html, since there's no means of checking the existence of an included file in SSI itself. We could write a small CGI process to check this and generate the authentication include on the fly, but that defeats the purpose of keeping the Hub otherwise all-static.
Mike Bland committedDec 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 80aa39b - Browse repository at this point
Copy the full SHA 80aa39bView commit details -
Pull upstream changes into _data/private
Mike Bland committedDec 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 8195583 - Browse repository at this point
Copy the full SHA 8195583View commit details
Commits on Dec 14, 2014
-
Remove unnecessary explicit truth check
Mike Bland committedDec 14, 2014 Configuration menu - View commit details
-
Copy full SHA for b0ef1bb - Browse repository at this point
Copy the full SHA b0ef1bbView commit details -
Improve generate_user_authentication_include() doc
Mike Bland committedDec 14, 2014 Configuration menu - View commit details
-
Copy full SHA for 07f2957 - Browse repository at this point
Copy the full SHA 07f2957View commit details -
More generate_user_authentication_include() detail
Mike Bland committedDec 14, 2014 Configuration menu - View commit details
-
Copy full SHA for 69a1a51 - Browse repository at this point
Copy the full SHA 69a1a51View commit details -
Replace $REMOTE_USER with $http_x_forwarded_email
After digging deeper into the origin of $REMOTE_USER at Aidan Feldman's request in #3, I realized that the user's entire email address was available to nginx's Server Side Include module via the embedded $http_x_forwarded_email variable, set by ngx_http_core_module: http://nginx.org/en/docs/http/ngx_http_core_module.html#var_http_ Using this to create each directory under _site/auth seems preferable to $REMOTE_USER, since having the domain name available as part of the generated directory name may help to avoid conflicts, should we ever wish to grant access to users from other domains.
Mike Bland committedDec 14, 2014 Configuration menu - View commit details
-
Copy full SHA for 4bdd9bf - Browse repository at this point
Copy the full SHA 4bdd9bfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.