-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
A couple other things to note:
|
Conflicts: _plugins/api.rb bower.json
Ok, merged |
Also, I normally don't advocate for rebasing/squashing commits once they're in a PR, but would understand if that were preferable in this case to remove the (essentially) duplicate commits from the split out PRs... let me know. |
Yeah, go ahead and squash and rebase and |
@@ -0,0 +1,36 @@ | |||
// https://github.com/mauriciogentile/angular-livesearch/blob/1f4e357ab3b50701eeedcfb45c12cd901d612087/example/styles.css#L31-L65 | |||
ul.searchresultspopup { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need the ul here? Why is .searchresultspopup not specific enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I copied-and-pasted this file from the URL above – didn't really spend any time cleaning it up. Worth a pass to delete anything we don't need, I gueeeeesssss 😑
Gonna merge now, but opening an issue to address @msecret's comments and the observation that the search box appears to only allow up to nine characters. |
Closes #42.
This is a superset of #69, but the generator has been moved to the jekyll_pages_api gem, and there is now client-side code to do searches, written in Angular (which was a fairly arbitrary choice).
Note that you can ignore anything under
assets/components/
, as those are all just vendored files.