Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic visual regression testing #158

Merged
merged 10 commits into from
Oct 14, 2020
Merged

Add basic visual regression testing #158

merged 10 commits into from
Oct 14, 2020

Commits on Oct 13, 2020

  1. Add basic visual regression testing

    @aduth
    aduth committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    25db3dc View commit details
    Browse the repository at this point in the history

  2. Add inline comments explaining RGBA 

    Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
    @aduth @zachmargolis
    aduth and zachmargolis committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    ed514d3 View commit details
    Browse the repository at this point in the history

  3. Readable-ize assertion error message

    @aduth
    aduth committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    b7e910f View commit details
    Browse the repository at this point in the history

  4. Use remote host for sitemap

    @aduth
    aduth committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    1cddbd0 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Split CircleCI jobs to isolate visual regression tests

    @aduth
    aduth committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    9397ea2 View commit details
    Browse the repository at this point in the history

  2. Add CircleCI workflows configuration 

    Required when not using singular "build" job
    @aduth
    aduth committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1274cc2 View commit details
    Browse the repository at this point in the history

  3. Upgrade CircleCI configuration to 2.1 

    Necessary for "commands" support

See: https://discuss.circleci.com/t/circleci-2-1-config-overview/26057
    @aduth
    aduth committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    49d1a19 View commit details
    Browse the repository at this point in the history

  4. Rename bundle-yarn-install to bundle-npm-install 

    Style guide not (currently) using Yarn
    @aduth
    aduth committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    3b90a27 View commit details
    Browse the repository at this point in the history

  5. Add README documentation for visual regression tests

    @aduth
    aduth committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    0bbb5a3 View commit details
    Browse the repository at this point in the history

  6. Remove acknowledged commit logic 

    New workflow will be to bypass failed result of visual regression test status check as implied acknowledgment of changes
    @aduth
    aduth committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    669cf2c View commit details
    Browse the repository at this point in the history