Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove layouts section #179

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Remove layouts section #179

merged 1 commit into from
Jan 20, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Jan 20, 2021

Why: The layouts are overly prescriptive, may fall (or have fallen) out of alignment with current recommendations, and are not the most useful of resources for referencing appearance or markup of page sections (footer, navigation, etc).

This removal should be complemented by future work to either:

  • Reference base components from USWDS for additional guidance
  • Document and list differences between USWDS footer / navigation and the login.gov Design System

**Why**: The layouts are overly prescriptive, may fall (or have fallen) out of alignment with current recommendations, and are not the most useful of resources for referencing appearance or markup of page sections (footer, navigation, etc).

This removal should be complemented by future work to either:
- Reference base components from USWDS for additional guidance
- Document and list differences between USWDS footer / navigation and the login.gov Design System
@aduth aduth requested a review from juliaelman January 20, 2021 18:53
Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliaelman juliaelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are wanting to remove this from the main navigation too, correct?

@aduth
Copy link
Member Author

aduth commented Jan 20, 2021

We are wanting to remove this from the main navigation too, correct?

Yeah, it should be removed with the changes here:

https://github.com/18F/identity-style-guide/pull/179/files#diff-833e7bb7ade39092fdeebe1d54db3a3ed970610ebe49e3b97f5e59da91c04edd

Are you still seeing it in the branch?

@juliaelman
Copy link
Member

Weird! It is gone now 🚀

@aduth aduth merged commit 77645c3 into main Jan 20, 2021
@aduth aduth deleted the aduth-remove-layouts branch January 20, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants