Remove Spinner component button variant #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why**: This is out of sync with current guidance, where buttons which trigger a waiting experience have since been refined within the IdP to display with a pulsing dot animation. See: LG-3730, LG-3787, 18F/identity-idp#4517
A 3.0.1 hasn't yet been published
zachmargolis
approved these changes
Jan 26, 2021
| <div class="lg-spinner lg-spinner--hidden" id="spinner-id"> | ||
| <div> | ||
| <img | ||
| src="{{ site.baseurl }}/assets/img/spinner.gif" |
There was a problem hiding this comment.
should we remove the spinner.gif and @2x files from this repo as well?
There was a problem hiding this comment.
should we remove the
spinner.gifand@2xfiles from this repo as well?
The spinner component itself will continue to exist after this, just not the button variant. We're still using the spinner in at least one place in the IdP (IAL2 Acuant modal overlay loading state).
|
Visual regression is expected for removed content from Spinner page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: This is out of sync with current guidance, where buttons which trigger a waiting experience have since been refined within the IdP to display with a pulsing dot animation.
See: LG-3730, LG-3787, 18F/identity-idp#4517
Future considerations: