Use login.gov shared ESLint configuration #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So Babel ESLint parser can parse
aduth
force-pushed
the
aduth-shared-eslint-config
branch
from
80163a4
to
9ac1560
Compare
**Why**: Because Jest (via babel-jest) automatically picks up this file and should be configured appropriately. See: - https://jestjs.io/docs/getting-started#using-babel - https://github.com/facebook/jest/blob/master/packages/babel-jest/README.md#usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: 18F/identity-idp#5359, GSA-TTS/identity-reporting#12
Why: So that we can use a common standard ruleset across all repositories where JavaScript is used.
Observations:
gulp-eslintis pinned to ESLint 6.x, which is very out-of-date, and replaced here with manual Gulp handling (see Upgrade to ESLint 8 adametry/gulp-eslint#250).