Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-5247: Add form input hint styles #262

Merged
merged 1 commit into from
Oct 15, 2021
Merged

LG-5247: Add form input hint styles #262

merged 1 commit into from
Oct 15, 2021

Conversation

aduth
Copy link
Member

@aduth aduth commented Oct 15, 2021

Copy link
Member

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Curiosity question: Here, the example is "000-123-4567" while the implemented example is "123-45-6789." Any reasons why they differ or if there is a case to use "000" digits over the latter?

Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth
Copy link
Member Author

aduth commented Oct 15, 2021

Curiosity question: Here, the example is "000-123-4567" while the implemented example is "123-45-6789." Any reasons why they differ or if there is a case to use "000" digits over the latter?

Ah, to be honest, I hadn't referenced the design for the specific text of the example. I chose the number because according to an SSA fact sheet I found via Google, a valid SSN would never start with 000.

@aduth aduth merged commit 64a042f into main Oct 15, 2021
@aduth aduth deleted the aduth-hint-italic branch October 15, 2021 17:04
@aduth aduth mentioned this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants