Add styles, scripts, and documentation for Alerts and Accordions. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These use the standard US Web Design System icons.
adunkman
commented
Jan 9, 2019
| rules: | ||
| import/no-extraneous-dependencies: | ||
| - error | ||
| - devDependencies: true |
There was a problem hiding this comment.
This enables JavaScript files to import npm packages listed as development dependencies for this project, which is required because all of our dependencies are specified as development dependencies (as we distribute compiled JavaScript as our production dependency).
donjo
approved these changes
Jan 10, 2019
|
Yeah! I’m thinking we might want to also include pygments-compatible syntax highlighting styles, since those would be used by the developer documentation sites at least. The style guide already generates pygments-compatible classes for code, we’d just need to add the classes to the stylesheet — but obviously a base container style for code samples would get us a long way, even if we don’t add the syntax highlighting. |
This was referenced Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the first additional JavaScript behavior, as Accordions in the US Web Design System do not have a Close button (other than clicking the header again).
I’ll be following up this PR with another PR that introduces integration tests of these accordions, as I’d like to assert their behavior (both the added close button and the standard US Web Design System behavior). I think that’s best suited for a follow-up PR as it’ll be the first integration tests for this repository, and will contain configuration and packages unrelated to these specific pages.
Without further ado: