-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-6485: Update line height value for accordion component #316
Conversation
**Why**: To improve readability when the accordion heading spans multiple lines of text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. TY!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The visual regression failure highlighted an interesting side-effect of this change: Since the "here's how you know" of the USA banner is implemented as an accordion, it was impacted by these changes, slightly increasing the height of the banner. I can bring that specific accordion button back down to the smaller line-height if you'd rather it not change, @nickttng ? |
@aduth After testing across browsers and widths, I think a slight increase is okay. Are you okay with it, too? Particularly if/when this is in effect with the IdP. |
I think it'd be fine too. Only other thing worth pointing out is I discovered USWDS does define some explicit line-height for the banner text ("Official website...") equivalent to |
Given the USWDS discovery, this makes sense. 👍🏼 |
Decrease from 1.5 to 1.2 to match See: #316 (comment)
Cool, I think so too 👍 Updated in 812f87a. |
Just inspected the latest built. Looking good. |
Why: To improve readability when the accordion heading spans multiple lines of text.
Live preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.app.cloud.gov/preview/18f/identity-style-guide/aduth-lg-6485-accordion-line-height/components/accordions/
Screenshots: