Implement form component styles. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donjo
suggested changes
Jan 23, 2019
After discussing this with some other visual designers it sounds like this may be "compliant" but not necessarily good. Is there an easy way to skip this test for disabled inputs as we work on some fresh button designs? I'll create a new issue for that. |
donjo
reviewed
Jan 30, 2019
These may not be non-compliant as they are disabled inputs, but we agree they should be improved in #49. This is a temporary fix until we redesign these.
|
I believe this should be ready for review again! |
donjo
approved these changes
Feb 1, 2019
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds styles and documentation for form fields (text inputs, dates, selects, radio buttons, and checkboxes).
This causes a build failure, due to insufficient contrast on the disabled input labels. We’ll need to discuss what to do to resolve that — not sure if we consider that a valid failure of accessibility.