LG-11082 Add Conditional Text To FullAddressSearch Component (#9331)

* Add conditional text to view * add new tests * Add period to display text * package version increase from 3.1.0 to 3.1.1 * fix linter errors * changelog: Upcoming feature, USPS Full Address Search, Added conditional logic to display/hide text on the Find a participating Post Office view that will display in Help Center only
18F · Oct 10, 2023 · 214b400 · 214b400
1 parent a3e45a7
commit 214b400
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 4 deletions.
diff --git a/app/javascript/packages/address-search/components/full-address-search.spec.tsx b/app/javascript/packages/address-search/components/full-address-search.spec.tsx
@@ -66,6 +66,51 @@ describe('FullAddressSearch', () => {
     });
   });
 
+  context('Address Search Label Text', () => {
+    it('does not render when handleLocationSelect is not null', async () => {
+      const handleLocationsFound = sandbox.stub();
+      const onSelect = sinon.stub();
+      const { queryByText } = render(
+        <SWRConfig value={{ provider: () => new Map() }}>
+          <FullAddressSearch
+            usStatesTerritories={usStatesTerritories}
+            onFoundLocations={handleLocationsFound}
+            locationsURL={locationsURL}
+            registerField={() => undefined}
+            handleLocationSelect={onSelect}
+            disabled={false}
+          />
+        </SWRConfig>,
+      );
+
+      const searchLabel = await queryByText(
+        'in_person_proofing.headings.po_search.address_search_label',
+      );
+      expect(searchLabel).to.be.empty;
+    });
+
+    it('renders when handleLocationSelect is null', async () => {
+      const handleLocationsFound = sandbox.stub();
+      const { queryByText } = render(
+        <SWRConfig value={{ provider: () => new Map() }}>
+          <FullAddressSearch
+            usStatesTerritories={usStatesTerritories}
+            onFoundLocations={handleLocationsFound}
+            locationsURL={locationsURL}
+            registerField={() => undefined}
+            handleLocationSelect={null}
+            disabled={false}
+          />
+        </SWRConfig>,
+      );
+
+      const searchLabel = await queryByText(
+        'in_person_proofing.body.location.po_search.address_search_label',
+      );
+      expect(searchLabel).to.exist();
+    });
+  });
+
   context('validates form', () => {
     it('displays an error for all required fields when input is empty', async () => {
       const handleLocationsFound = sandbox.stub();

diff --git a/app/javascript/packages/address-search/components/full-address-search.tsx b/app/javascript/packages/address-search/components/full-address-search.tsx
@@ -30,11 +30,13 @@ function FullAddressSearch({
           {t('idv.failure.exceptions.post_office_search_error')}
         </Alert>
       )}
-      {handleLocationSelect && (
+      {handleLocationSelect ? (
         <>
           <PageHeading>{t('in_person_proofing.headings.po_search.location')}</PageHeading>
           <p>{t('in_person_proofing.body.location.po_search.po_search_about')}</p>
         </>
+      ) : (
+        <p>{t('in_person_proofing.body.location.po_search.address_search_label')}</p>
       )}
       <FullAddressSearchInput
         usStatesTerritories={usStatesTerritories}

diff --git a/app/javascript/packages/address-search/package.json b/app/javascript/packages/address-search/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@18f/identity-address-search",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "type": "module",
   "private": false,
   "files": [

diff --git a/config/locales/in_person_proofing/en.yml b/config/locales/in_person_proofing/en.yml
@@ -39,7 +39,7 @@ en:
         po_search:
           address_label: Address
           address_search_hint: 'Example: 1234 N Example St., Allentown, PA 12345'
-          address_search_label: Enter an address to find a Post Office near you
+          address_search_label: Enter an address to find a Post Office near you.
           city_label: City
           is_searching_message: Searching for Post Office locations…
           none_found: Sorry, there are no participating Post Offices within 50 miles of

diff --git a/config/locales/in_person_proofing/es.yml b/config/locales/in_person_proofing/es.yml
@@ -42,7 +42,7 @@ es:
           address_label: Dirección
           address_search_hint: 'Ejemplo: 1234 N Example St., Allentown, PA 12345'
           address_search_label: Introduzca una dirección para encontrar una Oficina de
-            Correos cercana a usted
+            Correos cercana a usted.
           city_label: Ciudad
           is_searching_message: Buscando oficinas de correos…
           none_found: Lo sentimos, no hay Oficinas de Correos participantes en un radio de