LG-12030 Remove 'create' action from BackupCodeSetupController #10088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
kevinsmaster5
changed the base branch from
main
to
kmas-lg-12030-second-backup-code-warning
kevinsmaster5
changed the title
kevinsmaster5
force-pushed
the
kmas-lg-12030-delete-create
branch
from
437cf59
to
79b571d
Compare
kevinsmaster5
force-pushed
the
kmas-lg-12030-second-backup-code-warning
branch
from
67d44af
to
146cb85
Compare
kevinsmaster5
force-pushed
the
kmas-lg-12030-delete-create
branch
from
e7e1fde
to
51033bc
Compare
kevinsmaster5
force-pushed
the
kmas-lg-12030-second-backup-code-warning
branch
from
0c3605c
to
871c65f
Compare
kevinsmaster5
force-pushed
the
kmas-lg-12030-delete-create
branch
from
51033bc
to
fa6c393
Compare
kevinsmaster5
force-pushed
the
kmas-lg-12030-second-backup-code-warning
branch
2 times, most recently
from
c4bc096
to
0c12d42
Compare
Base automatically changed from
kmas-lg-12030-second-backup-code-warning
to
main
March 13, 2024 14:32
kevinsmaster5
force-pushed
the
kmas-lg-12030-delete-create
branch
from
906c986
to
92c9c52
Compare
aduth
reviewed
Apr 18, 2024
| @@ -280,7 +280,6 @@ | |||
| get '/backup_code_refreshed' => 'users/backup_code_setup#refreshed' | |||
| get '/backup_code_reminder' => 'users/backup_code_setup#reminder' | |||
| get '/backup_code_setup' => 'users/backup_code_setup#index' | |||
| patch '/backup_code_setup' => 'users/backup_code_setup#create', as: :backup_code_create | |||
There was a problem hiding this comment.
It looks like we still have something directing to this page, as production logs show activity for PATCH /backup_code_setup, so this is not safe to remove yet. I'll investigate.
There was a problem hiding this comment.
This should be fixed as of #10464, but will confirm once those changes go live in RC 374.
changelog: User-Facing Improvements, MFA, Remove backup code pre-warning from setup flow
aduth
force-pushed
the
kmas-lg-12030-delete-create
branch
from
4eb5b28
to
3313d1c
Compare
|
I squashed and rebased the branch to resolve conflicts and bring this up to date with main. |
aduth
approved these changes
Apr 23, 2024
samathad2023
pushed a commit
that referenced
this pull request
May 11, 2024
changelog: User-Facing Improvements, MFA, Remove backup code pre-warning from setup flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帿 Ticket
LG-12030
馃洜 Summary of changes
Follow on PR for #10014
Removes create action, route and view. Update specs accordingly.