Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-12294: Send aggregated email notification for new device sign-in #10314

Merged
merged 18 commits into from
Apr 4, 2024
Merged

LG-12294: Send aggregated email notification for new device sign-in #10314

merged 18 commits into from
Apr 4, 2024

Conversation

aduth
Copy link
Member

@aduth aduth commented Mar 26, 2024 •
edited

馃帿 Ticket

LG-12294

馃洜 Summary of changes

Adds a new email template for revised new-device sign-in notifications.

馃摐 Testing Plan

  1. Go to:
    1. Sign in before 2FA: http://localhost:3000/rails/mailers/user_mailer/new_device_sign_in_before_2fa
    2. Sign in before 2FA with multiple attempts: http://localhost:3000/rails/mailers/user_mailer/new_device_sign_in_before_2fa?failed_times=2
    3. Sign in after 2FA: http://localhost:3000/rails/mailers/user_mailer/new_device_sign_in_after_2fa
  2. Review content

馃憖 Screenshots

Before MFA After MFA
image image

aduth and others added 9 commits March 28, 2024 14:52
@aduth
LG-12294: Send aggregated email notification for new device sign-in
d12b003 
changelog: Upcoming Features, Sign In, Send single aggregated email notification for new device sign-in
@aduth
Localize to geocoded timezone if available
a2d0069
@aduth @zachmargolis
Move event grouping logic to mailer class
9ca5d56 
See: https://github.com/18F/identity-idp/pull/10314/files#r1540041239

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@aduth
Memoize user object for user mailer preview
5494ae8
@aduth
Use EasternTimePresenter for timestamp
544de0d
@aduth
Linkify authentication methods
f6110b9
@aduth
Update "potentially located in" language
baaf097 
https://gsa-tts.slack.com/archives/C05R6BLVAQG/p1711549883747499?thread_ts=1711476471.048729&cid=C05R6BLVAQG
@aduth
Add English string for sign_in_unsuccessful_2fa event
07923fb
@aduth
Track event sign_in_unsuccessful_2fa
58fb51b
@aduth aduth force-pushed the aduth-lg-12294-new-device-attempt-email branch from b6dfdc1 to 58fb51b Compare March 28, 2024 19:58
@aduth
Revert to uswds-core
ad67f20 
Original change was trying to resolve Sass error, fixed by reinstalling dependencies. Importing uswds-core ensures other overrides defined in stylesheets/_uswds-core.scss are applied
@aduth
Split separate mailers for sign in before/after 2fa
e934528 
The two content are more distinct than initially expected

See: https://github.com/18F/identity-idp/pull/10314/files#r1548593213
@aduth
Annotate used dynamic strings
eeb718f
@aduth
Add translations
9fc2cdf
@aduth
Interpolate app_name
cc55d7a
@aduth
Normalize YAML
872c002
@aduth
Sync preview name with mailer name
eba31e1
@aduth
Update French translation for failed times
4a753ca
@aduth aduth marked this pull request as ready for review April 3, 2024 15:55
@aduth aduth requested a review from a team April 3, 2024 15:55
jmdembe
jmdembe approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤馃従

@aduth aduth merged commit 0b2842d into main Apr 4, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-12294-new-device-attempt-email branch April 4, 2024 12:51
@aduth aduth mentioned this pull request Apr 5, 2024
Merged
@solipet solipet mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmargolis zachmargolis zachmargolis left review comments

@jmdembe jmdembe jmdembe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aduth @zachmargolis @jmdembe