LG-12596: Update security key setup page #10323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: User-Facing Improvements, Authentication, Update security key setup form
jc-gsa
changed the title
jc-gsa
changed the title
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
7112e0b
to
08a8657
Compare
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
08a8657
to
202f4ff
Compare
jc-gsa
commented
Mar 27, 2024
| <% end %> | ||
| <%= c.with_item(heading: t('forms.webauthn_setup.step_2')) do %> | ||
| <% if @mobile %> | ||
| <%= image_tag asset_url('mfa-options/security_key_mobile.gif'), class: 'rounded-xl', alt: t('forms.webauthn_setup.step_2_image_mobile_alt') %> |
There was a problem hiding this comment.
Open to different CSS classes for this style.
jc-gsa
commented
Mar 27, 2024
That's a good call-out, can you check to confirm with the UX team? Personally I would prefer that we have it, since remembered device is a big usability boost, and I wouldn't feel comfortable defaulting to remember without the user's awareness. |
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
9358beb
to
b723c56
Compare
…dentity-idp into LG-12596-Update-security-key-setup
aduth
reviewed
Mar 28, 2024
aduth
reviewed
Mar 28, 2024
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
8c7df36
to
851f88d
Compare
aduth
reviewed
Apr 2, 2024
jc-gsa
force-pushed
the
LG-12596-Update-security-key-setup
branch
from
7a5e979
to
5506917
Compare
aduth
approved these changes
Apr 2, 2024
zachmargolis
reviewed
Apr 3, 2024
aduth
approved these changes
Apr 4, 2024
Use SVG Animation for Yubikey images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12596
🛠 Summary of changes
Updates the security key setup page found at
/webauthn_setup.