Revert Change that Didnt Fix Blackscreen #10332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calls so user will have more relevant hint text
charleyf
commented
Apr 11, 2024
| @@ -513,15 +513,11 @@ function AcuantCapture( | |||
|
|
|||
| function onSelfieCaptureOpen() { | |||
| trackEvent('idv_sdk_selfie_image_capture_opened', { captureAttempts }); | |||
|
|
|||
| setImageCaptureText(''); | |||
There was a problem hiding this comment.
I'm not actually removing this, it's just moving into the acuant-selfie-camera onOpened function
| setIsCapturingEnvironment(true); | ||
| } | ||
|
|
||
| function onSelfieCaptureClosed() { | ||
| trackEvent('idv_sdk_selfie_image_capture_closed_without_photo', { captureAttempts }); | ||
|
|
||
| setImageCaptureText(''); |
There was a problem hiding this comment.
I'm not actually removing this, it's just moving into the acuant-selfie-camera onClosed function
| @@ -110,6 +112,7 @@ function AcuantSelfieCamera({ | |||
| }, | |||
| onPhotoTaken: () => { | |||
| // The photo has been taken and it's showing a preview with a button to accept or retake the image. | |||
| onImageCaptureFeedback(''); | |||
There was a problem hiding this comment.
This is getting added back, removed in the earlier PR.
|
Not sure what does following meant? @charleyf |
charleyf
commented
Apr 22, 2024
There was a problem hiding this comment.
Not sure what does following meant? @charleyf
It also adds an announcement (via hint text) when the selfie is captured.
@dawei-nava This is a leftover sentence that no longer reflects what I'm doing in the PR. Removed! Thanks
dawei-nava
approved these changes
Apr 22, 2024
night-jellyfish
approved these changes
Apr 22, 2024
charleyf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR rolls back the changes here because they didn't fix the blackscreen issue.